Skip to content

Update subscriber example in README to current patterns.#6194

Merged
tseaver merged 3 commits into
googleapis:masterfrom
tseaver:6189-pubsub-update_readme_subscriber_example
Oct 12, 2018
Merged

Update subscriber example in README to current patterns.#6194
tseaver merged 3 commits into
googleapis:masterfrom
tseaver:6189-pubsub-update_readme_subscriber_example

Conversation

@tseaver

@tseaver tseaver commented Oct 11, 2018

Copy link
Copy Markdown
Contributor

Closes #6189.

@tseaver tseaver added documentation api: pubsub Issues related to the Pub/Sub API. labels Oct 11, 2018
@tseaver tseaver requested review from crwilcox and theacodes October 11, 2018 15:38
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 11, 2018

@anguillanneuf anguillanneuf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also update from google.cloud import pubsub_v1?

It's because everywhere else - in the API Library Doc, such as this page: https://googleapis.github.io/google-cloud-python/latest/pubsub/publisher/api/client.html, as well as in our doc samples - we use pubsub_v1.

Or at lease do from google.cloud import pubsub_v1 as pubsub, so people will expect that they won't run into any issues using v1.

@tseaver

tseaver commented Oct 12, 2018

Copy link
Copy Markdown
Contributor Author

@anguillanneuf

Could we also update from google.cloud import pubsub_v1?

See aae840a .

@anguillanneuf anguillanneuf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the same import statement update for the publisher code block.

@anguillanneuf anguillanneuf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, approved too quickly. Would need changes on publisher code block too.

@tseaver

tseaver commented Oct 12, 2018

Copy link
Copy Markdown
Contributor Author

@anguillanneuf

Oops, approved too quickly. Would need changes on publisher code block too.

See fee1735

@tseaver tseaver merged commit 987d410 into googleapis:master Oct 12, 2018
@tseaver tseaver deleted the 6189-pubsub-update_readme_subscriber_example branch October 12, 2018 22:39
parthea pushed a commit that referenced this pull request Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants