Skip to content

Commit 611730b

Browse files
benfrybenfry
committed
remove a handful of warnings
1 parent c6bc865 commit 611730b

File tree

5 files changed

+21
-9
lines changed

5 files changed

+21
-9
lines changed

‎core/.settings/org.eclipse.jdt.core.prefs‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
eclipse.preferences.version=1
2+
org.eclipse.jdt.core.compiler.annotation.inheritNullAnnotations=disabled
23
org.eclipse.jdt.core.compiler.annotation.missingNonNullByDefaultAnnotation=ignore
34
org.eclipse.jdt.core.compiler.annotation.nonnull=org.eclipse.jdt.annotation.NonNull
45
org.eclipse.jdt.core.compiler.annotation.nonnullbydefault=org.eclipse.jdt.annotation.NonNullByDefault
@@ -47,6 +48,7 @@ org.eclipse.jdt.core.compiler.problem.missingSynchronizedOnInheritedMethod=ignor
4748
org.eclipse.jdt.core.compiler.problem.noEffectAssignment=warning
4849
org.eclipse.jdt.core.compiler.problem.noImplicitStringConversion=warning
4950
org.eclipse.jdt.core.compiler.problem.nonExternalizedStringLiteral=ignore
51+
org.eclipse.jdt.core.compiler.problem.nonnullParameterAnnotationDropped=warning
5052
org.eclipse.jdt.core.compiler.problem.nullAnnotationInferenceConflict=error
5153
org.eclipse.jdt.core.compiler.problem.nullReference=warning
5254
org.eclipse.jdt.core.compiler.problem.nullSpecViolation=error
@@ -67,6 +69,7 @@ org.eclipse.jdt.core.compiler.problem.specialParameterHidingField=disabled
6769
org.eclipse.jdt.core.compiler.problem.staticAccessReceiver=warning
6870
org.eclipse.jdt.core.compiler.problem.suppressOptionalErrors=disabled
6971
org.eclipse.jdt.core.compiler.problem.suppressWarnings=enabled
72+
org.eclipse.jdt.core.compiler.problem.syntacticNullAnalysisForFields=disabled
7073
org.eclipse.jdt.core.compiler.problem.syntheticAccessEmulation=ignore
7174
org.eclipse.jdt.core.compiler.problem.typeParameterHiding=warning
7275
org.eclipse.jdt.core.compiler.problem.unavoidableGenericTypeProblems=enabled
@@ -75,7 +78,7 @@ org.eclipse.jdt.core.compiler.problem.unclosedCloseable=warning
7578
org.eclipse.jdt.core.compiler.problem.undocumentedEmptyBlock=ignore
7679
org.eclipse.jdt.core.compiler.problem.unhandledWarningToken=warning
7780
org.eclipse.jdt.core.compiler.problem.unnecessaryElse=ignore
78-
org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=ignore
81+
org.eclipse.jdt.core.compiler.problem.unnecessaryTypeCheck=warning
7982
org.eclipse.jdt.core.compiler.problem.unqualifiedFieldAccess=ignore
8083
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownException=ignore
8184
org.eclipse.jdt.core.compiler.problem.unusedDeclaredThrownExceptionExemptExceptionAndThrowable=enabled
@@ -90,6 +93,7 @@ org.eclipse.jdt.core.compiler.problem.unusedParameterIncludeDocCommentReference=
9093
org.eclipse.jdt.core.compiler.problem.unusedParameterWhenImplementingAbstract=disabled
9194
org.eclipse.jdt.core.compiler.problem.unusedParameterWhenOverridingConcrete=disabled
9295
org.eclipse.jdt.core.compiler.problem.unusedPrivateMember=warning
96+
org.eclipse.jdt.core.compiler.problem.unusedTypeParameter=ignore
9397
org.eclipse.jdt.core.compiler.problem.unusedWarningToken=warning
9498
org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning
9599
org.eclipse.jdt.core.compiler.source=1.6

‎core/src/processing/core/PGraphicsJava2D.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2364,7 +2364,7 @@ protected WritableRaster getRaster() {
23642364
if (primarySurface) {
23652365
// 'offscreen' will probably be removed in the next release
23662366
if (useOffscreen) {
2367-
raster = ((BufferedImage) offscreen).getRaster();
2367+
raster = offscreen.getRaster();
23682368
} else if (image instanceof VolatileImage) {
23692369
// when possible, we'll try VolatileImage
23702370
raster = ((VolatileImage) image).getSnapshot().getRaster();

‎core/src/processing/data/JSONObject.java‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1644,10 +1644,10 @@ static protected String valueToString(Object value) {
16441644
return value.toString();
16451645
}
16461646
if (value instanceof Map) {
1647-
return new JSONObject((Map)value).toString();
1647+
return new JSONObject(value).toString();
16481648
}
16491649
if (value instanceof Collection) {
1650-
return new JSONArray((Collection)value).toString();
1650+
return new JSONArray(value).toString();
16511651
}
16521652
if (value.getClass().isArray()) {
16531653
return new JSONArray(value).toString();
@@ -1683,13 +1683,13 @@ static protected Object wrap(Object object) {
16831683
}
16841684

16851685
if (object instanceof Collection) {
1686-
return new JSONArray((Collection)object);
1686+
return new JSONArray(object);
16871687
}
16881688
if (object.getClass().isArray()) {
16891689
return new JSONArray(object);
16901690
}
16911691
if (object instanceof Map) {
1692-
return new JSONObject((Map)object);
1692+
return new JSONObject(object);
16931693
}
16941694
Package objectPackage = object.getClass().getPackage();
16951695
String objectPackageName = objectPackage != null
@@ -1732,9 +1732,9 @@ static final Writer writeValue(Writer writer, Object value,
17321732
} else if (value instanceof JSONArray) {
17331733
((JSONArray) value).write(writer, indentFactor, indent);
17341734
} else if (value instanceof Map) {
1735-
new JSONObject((Map) value).write(writer, indentFactor, indent);
1735+
new JSONObject(value).write(writer, indentFactor, indent);
17361736
} else if (value instanceof Collection) {
1737-
new JSONArray((Collection) value).write(writer, indentFactor,
1737+
new JSONArray(value).write(writer, indentFactor,
17381738
indent);
17391739
} else if (value.getClass().isArray()) {
17401740
new JSONArray(value).write(writer, indentFactor, indent);

‎core/src/processing/opengl/PJOGL.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -961,7 +961,7 @@ protected void nativeKeyEvent(com.jogamp.newt.event.KeyEvent nativeEvent,
961961
InputEvent.ALT_MASK);
962962

963963
char keyChar;
964-
if ((int)nativeEvent.getKeyChar() == 0) {
964+
if (nativeEvent.getKeyChar() == 0) {
965965
keyChar = PConstants.CODED;
966966
} else {
967967
keyChar = nativeEvent.getKeyChar();

‎core/todo.txt‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,20 @@ X text looks lousy compared to the Apple JVM
66
X mess with rendering hints? (notes in PGraphicsJava2D)
77
X improvements made, but still not amazing.. just at level of Windows/Linux
88

9+
_ default font fixes
10+
_ https://github.com/processing/processing/issues/2331
11+
_ https://github.com/processing/processing/pull/2338
12+
913
fixed in 2.1
1014
X draw() called again before finishing on OS X (retina issue)
1115
X https://github.com/processing/processing/issues/1709
1216
X get() not always setting alpha channel when used with point()
1317
X https://github.com/processing/processing/issues/1756
1418

19+
A depth buffer shouldn't be cleared when depth mask is disabled
20+
A https://github.com/processing/processing/issues/2296
21+
A set pixels transparent by default in P2D/P3D
22+
A https://github.com/processing/processing/issues/2207
1523

1624
_ saveFrame() with retina render is making black images
1725
_ add print() method to other data types (not just IntList)

0 commit comments

Comments
 (0)