pythonGH-104584: Fix refleak when tracing through calls (pythonGH-110593)

brandtbucher · Glyphack · commit 930819203a61 · 2024-01-27T10:36:21.000+01:00
diff --git a/Misc/NEWS.d/next/Core and Builtins/2023-10-10-00-49-35.gh-issue-104584.z94TuJ.rst b/Misc/NEWS.d/next/Core and Builtins/2023-10-10-00-49-35.gh-issue-104584.z94TuJ.rst
@@ -0,0 +1 @@
+Fix a reference leak when running with :envvar:`PYTHONUOPS` or :option:`-X uops <-X>` enabled.
diff --git a/Objects/funcobject.c b/Objects/funcobject.c
@@ -288,7 +288,7 @@ _PyFunction_LookupByVersion(uint32_t version)
     PyFunctionObject *func = interp->func_state.func_version_cache[
         version % FUNC_VERSION_CACHE_SIZE];
     if (func != NULL && func->func_version == version) {
-        return (PyFunctionObject *)Py_NewRef(func);
+        return func;
     }
     return NULL;
 }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	+Fix a reference leak when running with :envvar:`PYTHONUOPS` or :option:`-X uops <-X>` enabled.
Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,7 @@ _PyFunction_LookupByVersion(uint32_t version)`
`288`	`288`	`PyFunctionObject *func = interp->func_state.func_version_cache[`
`289`	`289`	`version % FUNC_VERSION_CACHE_SIZE];`
`290`	`290`	`if (func != NULL && func->func_version == version) {`
`291`		`- return (PyFunctionObject *)Py_NewRef(func);`
	`291`	`+ return func;`
`292`	`292`	`}`
`293`	`293`	`return NULL;`
`294`	`294`	`}`