feat: implement adminlist and root config directories#3
Conversation
…ot directory - Shifted configuration files (`server-settings.json` and `server-adminlist.json`) to the root of the repository to prevent them from being lost if the Factorio directory is updated or deleted. - Added support for `server-adminlist.json`. - Added a new main menu option to easily edit the admin list through the GUI. - Added dynamic launch arguments so configuration files are only passed to the server if they exist. - Implemented these changes across both the PowerShell (`FactorioServerManager.ps1`) and batch (`example_batch.bat`) scripts. - Updated documentation (`README.md` & `CHANGELOG.md`) to reflect the v1.1.0 changes.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 18cab5d56d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (Test-Path $adminListPath) { | ||
| $args += '--server-adminlist' | ||
| $args += "`"$adminListPath`"" |
There was a problem hiding this comment.
Do not pass the bundled placeholder admin list
On a fresh checkout, the repository already contains server-adminlist.json with sample entries (username1 and username2), so this Test-Path branch is always taken and every server launch grants admin privileges to those Factorio account names if they exist. Treat the checked-in file as an example or initialize an empty/user-created admin list before passing --server-adminlist.
Useful? React with 👍 / 👎.
| if (Test-Path $settingsPath) { | ||
| $args += '--server-settings' | ||
| $args += "`"$settingsPath`"" |
There was a problem hiding this comment.
Avoid launching with placeholder root settings
Because server-settings.json is already checked into the repo, this existence check is true on first run and the manager now launches with the bundled placeholder config before the operator edits it. That file sets public visibility and contains placeholder credentials/known game password, so fresh launches can fail authentication or expose a server with unintended defaults; use safe generated defaults or keep the tracked file as an example instead of always passing it.
Useful? React with 👍 / 👎.
This PR updates the Factorio Server Manager to store configuration files (
server-settings.jsonandserver-adminlist.json) in the root directory rather than within the managedFactorio/structure, ensuring configurations aren't wiped or overwritten by updates. It adds support for the admin list to the manager's GUI, introduces dynamic argument checking for launch commands, and updates theexample_batch.batand all documentation to keep everything professionally matched for the 1.1 release.PR created automatically by Jules for task 17277329387878516801 started by @GhostwheeI