Skip to content

feat: add restore_users#134

Merged
yaziine merged 4 commits into
masterfrom
restore-users
Nov 8, 2022
Merged

feat: add restore_users#134
yaziine merged 4 commits into
masterfrom
restore-users

Conversation

@yaziine
Copy link
Copy Markdown
Contributor

@yaziine yaziine commented Nov 7, 2022

No description provided.

Comment thread stream_chat/async_chat/client.py Outdated
Comment thread stream_chat/client.py Outdated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ferhatelmas
Copy link
Copy Markdown
Contributor

@yaziine this change looks good but could you fix the issue in main so that CI becomes green (not from you) and please don't forget adding python snippets into docs for new endpoint.

Not strictly needed but I would suggest adding other languages while on it

@ferhatelmas
Copy link
Copy Markdown
Contributor

ferhatelmas commented Nov 8, 2022

@yaziine let's merge this, I will check mypy thing later

ferhatelmas
ferhatelmas previously approved these changes Nov 8, 2022
@yaziine
Copy link
Copy Markdown
Contributor Author

yaziine commented Nov 8, 2022

@ferhatelmas latest releases of mypy adds more rules. Don't think they are relevant to us, just disabled them.

@yaziine yaziine requested a review from ferhatelmas November 8, 2022 10:08
@yaziine yaziine merged commit 0d57324 into master Nov 8, 2022
@yaziine yaziine deleted the restore-users branch November 8, 2022 10:15
@github-actions github-actions Bot mentioned this pull request Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants