Use logger's built-in string formatting rather than concatenation

dpursehouse · dpursehouse · commit fb9a2a9b59a3 · 2020-02-19T10:45:07.000+09:00
Change-Id: I4dc397fd418f1237cc3cc6194565ab3204c1acb9
diff --git a/java/com/google/gitiles/BlobSoyData.java b/java/com/google/gitiles/BlobSoyData.java
@@ -136,7 +136,7 @@ private List<ParseResult> parse(String path, String content) {
     } catch (StackOverflowError e) {
       // TODO(dborowitz): Aaagh. Make prettify use RE2. Or replace it something
       // else. Or something.
-      log.warn("StackOverflowError prettifying " + view.toUrl());
+      log.warn("StackOverflowError prettifying {}", view.toUrl());
       return ImmutableList.of(
           new ParseResult(0, content.length(), ImmutableList.of(Prettify.PR_PLAIN)));
     }
diff --git a/java/com/google/gitiles/Linkifier.java b/java/com/google/gitiles/Linkifier.java
@@ -83,7 +83,7 @@ public Linkifier(GitilesUrls urls, Config config) {
         if (log.isDebugEnabled()) {
           log.debug(msg, ex);
         } else {
-          log.warn(msg + ": " + ex.getMessage());
+          log.warn("{}: {}", msg, ex.getMessage());
         }
         continue;
       }

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ private List<ParseResult> parse(String path, String content) {`
`136`	`136`	`} catch (StackOverflowError e) {`
`137`	`137`	`// TODO(dborowitz): Aaagh. Make prettify use RE2. Or replace it something`
`138`	`138`	`// else. Or something.`
`139`		`- log.warn("StackOverflowError prettifying " + view.toUrl());`
	`139`	`+ log.warn("StackOverflowError prettifying {}", view.toUrl());`
`140`	`140`	`return ImmutableList.of(`
`141`	`141`	`new ParseResult(0, content.length(), ImmutableList.of(Prettify.PR_PLAIN)));`
`142`	`142`	`}`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ public Linkifier(GitilesUrls urls, Config config) {`
`83`	`83`	`if (log.isDebugEnabled()) {`
`84`	`84`	`log.debug(msg, ex);`
`85`	`85`	`} else {`
`86`		`- log.warn(msg + ": " + ex.getMessage());`
	`86`	`+ log.warn("{}: {}", msg, ex.getMessage());`
`87`	`87`	`}`
`88`	`88`	`continue;`
`89`	`89`	`}`