ViewFilter: Fix reference comparison of Revision

dpursehouse · dpursehouse · commit fb3daadea1c9 · 2019-06-05T13:46:11.000+09:00
Change-Id: I4bc72df1e8effa394617ef9b3ed6e03718b2a76f
diff --git a/java/com/google/gitiles/ViewFilter.java b/java/com/google/gitiles/ViewFilter.java
@@ -124,7 +124,7 @@ private boolean normalize(GitilesView.Builder view, HttpServletResponse res) thr
     }
     Revision r = view.getRevision();
     Revision nr = Revision.normalizeParentExpressions(r);
-    if (r != nr) {
+    if (!r.equals(nr)) {
       res.sendRedirect(view.setRevision(nr).toUrl());
       return true;
     }

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ private boolean normalize(GitilesView.Builder view, HttpServletResponse res) thr`
`124`	`124`	`}`
`125`	`125`	`Revision r = view.getRevision();`
`126`	`126`	`Revision nr = Revision.normalizeParentExpressions(r);`
`127`		`- if (r != nr) {`
	`127`	`+ if (!r.equals(nr)) {`
`128`	`128`	`res.sendRedirect(view.setRevision(nr).toUrl());`
`129`	`129`	`return true;`
`130`	`130`	`}`