BlameCacheImpl: making loadRegions() public

xingkhuang1412 · xingkhuang1412 · commit 4ea413d5f74b · 2024-08-14T16:20:36.000-05:00
Making loadRegions() public will give us more customization options by allowing us to pass in any form of pre-determined BlameGenerator. Since this is a static method, no state is recorded within the BlameCacheImpl object, this should be a no-op.

Change-Id: I8f684bcda237ca849743a2fde3a3b8cc9955eabe
Signed-off-by: Xing Huang &lt;xingkhuang@google.com&gt;
diff --git a/java/com/google/gitiles/blame/cache/BlameCacheImpl.java b/java/com/google/gitiles/blame/cache/BlameCacheImpl.java
@@ -163,7 +163,7 @@ private PooledCommit(ObjectId commit, PersonIdent author) {
     }
   }
 
-  private static List<Region> loadRegions(BlameGenerator gen) throws IOException {
+  public static List<Region> loadRegions(BlameGenerator gen) throws IOException {
     Map<ObjectId, PooledCommit> commits = Maps.newHashMap();
     Interner<String> strings = Interners.newStrongInterner();
     int lineCount = gen.getResultContents().size();

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ private PooledCommit(ObjectId commit, PersonIdent author) {`
`163`	`163`	`}`
`164`	`164`	`}`
`165`	`165`
`166`		`- private static List<Region> loadRegions(BlameGenerator gen) throws IOException {`
	`166`	`+ public static List<Region> loadRegions(BlameGenerator gen) throws IOException {`
`167`	`167`	`Map<ObjectId, PooledCommit> commits = Maps.newHashMap();`
`168`	`168`	`Interner<String> strings = Interners.newStrongInterner();`
`169`	`169`	`int lineCount = gen.getResultContents().size();`