Skip to content

Commit 3863a1e

Browse files
committed
BaseServlet: Add Javadoc for IOException to prevent Eclipse warnings
The IOException is not thrown from the methods as implemented in the base class, but from the overridden implementations in the derived classes. Add Javadoc @throws tags to prevent Eclipse from complaining that the exceptions are not thrown. Change-Id: I55a225a80b819b2156c52fffe0e2f87482a5abb5
1 parent c53de2b commit 3863a1e

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

java/com/google/gitiles/BaseServlet.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ protected FormatType getDefaultFormat(HttpServletRequest req) {
145145
*
146146
* @param req in-progress request.
147147
* @param res in-progress response.
148+
* @throws IOException if there was an error rendering the result.
148149
*/
149150
protected void doGetHtml(HttpServletRequest req, HttpServletResponse res) throws IOException {
150151
throw new GitilesRequestFailureException(FailureReason.UNSUPPORTED_RESPONSE_FORMAT);
@@ -155,6 +156,7 @@ protected void doGetHtml(HttpServletRequest req, HttpServletResponse res) throws
155156
*
156157
* @param req in-progress request.
157158
* @param res in-progress response.
159+
* @throws IOException if there was an error rendering the result.
158160
*/
159161
protected void doGetText(HttpServletRequest req, HttpServletResponse res) throws IOException {
160162
throw new GitilesRequestFailureException(FailureReason.UNSUPPORTED_RESPONSE_FORMAT);
@@ -165,6 +167,7 @@ protected void doGetText(HttpServletRequest req, HttpServletResponse res) throws
165167
*
166168
* @param req in-progress request.
167169
* @param res in-progress response.
170+
* @throws IOException if there was an error rendering the result.
168171
*/
169172
protected void doGetJson(HttpServletRequest req, HttpServletResponse res) throws IOException {
170173
throw new GitilesRequestFailureException(FailureReason.UNSUPPORTED_RESPONSE_FORMAT);

0 commit comments

Comments
 (0)