Remove unused guice dependency

davido · davido · commit 34d1324e3c18 · 2023-09-28T14:52:01.000+02:00
Guice doesn't seem to be used. Remove it and all it transitive
dependencies. Also remove specifications for error prone bug patterns
related to dependency injection.

Change-Id: I0edfb951e292ed583a16743a5f8ea9b35d76f397
diff --git a/WORKSPACE b/WORKSPACE
@@ -257,32 +257,6 @@ maven_jar(
     sha1 = "a41f9cfe6faafb2eb83a1c7dd2d0dfd844e2a936",
 )
 
-GUICE_VERSION = "5.0.1"
-
-maven_jar(
-    name = "guice-library",
-    artifact = "com.google.inject:guice:" + GUICE_VERSION,
-    sha1 = "0dae7556b441cada2b4f0a2314eb68e1ff423429",
-)
-
-maven_jar(
-    name = "guice-assistedinject",
-    artifact = "com.google.inject.extensions:guice-assistedinject:" + GUICE_VERSION,
-    sha1 = "62e02f2aceb7d90ba354584dacc018c1e94ff01c",
-)
-
-maven_jar(
-    name = "aopalliance",
-    artifact = "aopalliance:aopalliance:1.0",
-    sha1 = "0235ba8b489512805ac13a8f9ea77a1ca5ebe3e8",
-)
-
-maven_jar(
-    name = "javax-inject",
-    artifact = "javax.inject:javax.inject:1",
-    sha1 = "6975da39a7040257bd51d21a231b76c915872d38",
-)
-
 JETTY_VERSION = "9.4.49.v20220914"
 
 maven_jar(
diff --git a/java/com/google/gitiles/BUILD b/java/com/google/gitiles/BUILD
@@ -25,7 +25,6 @@ DEPS = [
 
 DEPS_ALL = DEPS + [
     "//lib:jgit-archive",
-    "//lib/guice:guice",
 ]
 
 java_library(
diff --git a/lib/guice/BUILD b/lib/guice/BUILD
diff --git a/tools/BUILD b/tools/BUILD
@@ -60,7 +60,6 @@ java_package_configuration(
         "-Xep:ImmutableAnnotationChecker:ERROR",
         "-Xep:ImmutableEnumChecker:WARN",
         "-Xep:IncompatibleModifiers:ERROR",
-        "-Xep:InjectOnConstructorOfAbstractClass:ERROR",
         "-Xep:InputStreamSlowMultibyteRead:ERROR",
         "-Xep:IterableAndIterator:ERROR",
         "-Xep:JUnit3FloatingPointComparisonWithoutDelta:ERROR",
@@ -77,7 +76,6 @@ java_package_configuration(
         "-Xep:NullablePrimitive:ERROR",
         "-Xep:NullableVoid:ERROR",
         "-Xep:OperatorPrecedence:ERROR",
-        "-Xep:OverridesGuiceInjectableMethod:ERROR",
         "-Xep:PreconditionsInvalidPlaceholder:ERROR",
         "-Xep:ProtoFieldPreconditionsCheckNotNull:ERROR",
         "-Xep:ProtocolBufferOrdinal:ERROR",

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,6 @@ DEPS = [`
`25`	`25`
`26`	`26`	`DEPS_ALL = DEPS + [`
`27`	`27`	`"//lib:jgit-archive",`
`28`		`- "//lib/guice:guice",`
`29`	`28`	`]`
`30`	`29`
`31`	`30`	`java_library(`