fs: harden fs.read(params, callback) typecheck

LiviaMedeiros · Fyko · commit a8859951c03e · 2022-09-15T16:56:20.000-06:00
PR-URL: nodejs#42772 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/fs.js b/lib/fs.js
@@ -639,6 +639,9 @@ function read(fd, buffer, offsetOrOptions, length, position, callback) {
       buffer = Buffer.alloc(16384);
     }
 
+    if (params !== undefined) {
+      validateObject(params, 'options', { nullable: true });
+    }
     ({
       offset = 0,
       length = buffer.byteLength - offset,

Original file line number	Diff line number	Diff line change
`@@ -639,6 +639,9 @@ function read(fd, buffer, offsetOrOptions, length, position, callback) {`
`639`	`639`	`buffer = Buffer.alloc(16384);`
`640`	`640`	`}`
`641`	`641`
	`642`	`+ if (params !== undefined) {`
	`643`	`+ validateObject(params, 'options', { nullable: true });`
	`644`	`+ }`
`642`	`645`	`({`
`643`	`646`	`offset = 0,`
`644`	`647`	`length = buffer.byteLength - offset,`