Merge pull request #2 from FrontierDevelopmentLab/improvements-readme-and-rough-edges

will-fawcett-trillium · web-flow · commit f8389f3ab3d4 · 2026-04-30T09:58:36.000+01:00
Improvements readme and rough edges
diff --git a/README.md b/README.md
@@ -1,5 +1,9 @@
 # eve-api
 
+[![CI](https://github.com/FrontierDevelopmentLab/eve-api/actions/workflows/main.yml/badge.svg)](https://github.com/FrontierDevelopmentLab/eve-api/actions/workflows/main.yml)
+[![Python](https://img.shields.io/badge/python-3.11%20%7C%203.12%20%7C%203.13%20%7C%203.14-blue)](https://github.com/FrontierDevelopmentLab/eve-api)
+[![License: MIT](https://img.shields.io/badge/license-MIT-green)](LICENSE)
+
 Minimal authenticated HTTP client for the EVE (Earth Virtual Expert) API.
 
 Provides login, automatic JWT token refresh, and generic HTTP methods that return plain dicts. No domain-specific wrappers or Pydantic models.
diff --git a/src/eve_api/client.py b/src/eve_api/client.py
@@ -356,7 +356,7 @@ def _handle_error(response: httpx.Response) -> None:
             message = response.text or f"HTTP {status}"
 
         if status == HTTPStatus.NOT_FOUND:
-            raise NotFoundError("resource", "unknown")
+            raise NotFoundError(message)
         if status == HTTPStatus.FORBIDDEN:
             raise ForbiddenError(message)
         if status == HTTPStatus.BAD_REQUEST:
diff --git a/src/eve_api/exceptions.py b/src/eve_api/exceptions.py
@@ -58,17 +58,22 @@ def __init__(
 class NotFoundError(APIError):
     """Raised when a requested resource is not found (404)."""
 
-    def __init__(self, resource: str, resource_id: str) -> None:
+    def __init__(
+        self,
+        message: str = "Resource not found",
+        details: dict[str, Any] | None = None,
+    ) -> None:
         """Initialise the not found error.
 
         Args:
-            resource: Type of resource (e.g., 'conversation', 'document').
-            resource_id: ID of the resource that was not found.
+            message: Human-readable error message (typically the server's
+                ``detail`` field).
+            details: Additional error details from the response body.
         """
         super().__init__(
-            f"{resource.title()} not found: {resource_id}",
+            message,
             status_code=HTTPStatus.NOT_FOUND,
-            details={"resource": resource, "id": resource_id},
+            details=details,
         )
 
 
diff --git a/tests/test_client.py b/tests/test_client.py
@@ -236,7 +236,7 @@ async def test_404_raises_not_found(mock_api, authenticated_client: EVEClient):
         )
     )
 
-    with pytest.raises(NotFoundError) as exc_info:
+    with pytest.raises(NotFoundError, match="Not found") as exc_info:
         await authenticated_client.get("/conversations/missing")
 
     assert exc_info.value.status_code == HTTPStatus.NOT_FOUND

Original file line number	Diff line number	Diff line change
`@@ -236,7 +236,7 @@ async def test_404_raises_not_found(mock_api, authenticated_client: EVEClient):`
`236`	`236`	`)`
`237`	`237`	`)`
`238`	`238`
`239`		`- with pytest.raises(NotFoundError) as exc_info:`
	`239`	`+ with pytest.raises(NotFoundError, match="Not found") as exc_info:`
`240`	`240`	`await authenticated_client.get("/conversations/missing")`
`241`	`241`
`242`	`242`	`assert exc_info.value.status_code == HTTPStatus.NOT_FOUND`