updates duplex lib to fix cork,uncork and change the behavior of writeHead slightly. These three methods are now chainable. (gabrielcsapo#27)

echopoint · gabrielcsapo · commit faad289b2acb · 2017-11-10T14:28:09.000-08:00
diff --git a/lib/http-duplex.js b/lib/http-duplex.js
@@ -231,6 +231,61 @@ class HttpDuplex extends EventEmitter {
     get writable() {
         return this.res.writable;
     }
+
+    /**
+     * Sends a response header to the client request. Must only be called one time and before calling response.end().
+     * @method writeHead
+     * @alias HttpDuplex.writeHead
+     * @memberof HttpDuplex
+     * @param {number} statusCode 3-digit HTTP status code, like 404
+     * @param {string} [statusMessage] An optional human readable status message to send with the status code
+     * @param {object} [headers] An object containing the response headers to send
+     * @returns {this}
+     * @see {@link https://nodejs.org/api/http.html#http_response_writehead_statuscode_statusmessage_headers|response.writeHead}
+     * @example var content = 'Under Construction...';
+     * response.writeHead(200, {
+     *     'Content-Length': Buffer.byteLength(content),
+     *     'Content-Type': 'text/plain' 
+     * });
+     * response.end(content);
+     */
+    writeHead(statusCode, statusMessage, headers) {
+        this.res.writeHead(statusCode, statusMessage, headers);
+        return this;
+    }
+
+    /**
+     * Buffers written data in memory. This data will be flushed when either the uncork or end methods are called.
+     * @method cork
+     * @alias HttpDuplex.cork
+     * @memberof HttpDuplex
+     * @returns {this}
+     * @see uncork
+     * @see {@link https://nodejs.org/api/stream.html#stream_writable_cork|stream.Writeable.cork}
+     * @example
+     * request.cork();
+     * request.write('buffer data ');
+     * request.write('before sending ');
+     * request.uncork();
+     */
+    cork() {
+        this.res.connection.cork();
+        return this;
+    }
+
+    /**
+     * Flushes all data buffered since cork() was called.
+     * @method uncork
+     * @alias HttpDuplex.cork
+     * @memberof HttpDuplex
+     * @returns {this}
+     * @see cork
+     * @see {@link https://nodejs.org/api/stream.html#stream_writable_uncork|stream.Writeable.uncork}
+     */
+    uncork() {
+        this.res.connection.uncork();
+        return this;
+    }
 }
 
 // proxy request methods
@@ -242,7 +297,7 @@ class HttpDuplex extends EventEmitter {
 
 // proxy respone methods
 [
-    'cork', 'uncork', 'setDefaultEncoding', 'write', 'end', 'flush', 'writeHeader', 'writeHead', 'writeContinue',
+    'setDefaultEncoding', 'write', 'end', 'flush', 'writeHeader', 'writeContinue',
     'setHeader', 'getHeader', 'removeHeader', 'addTrailers'
 ].forEach(function (name) {
     HttpDuplex.prototype[name] = function () {
@@ -334,20 +389,6 @@ module.exports = HttpDuplex;
  * @see {@link https://nodejs.org/api/http.html#http_response_addtrailers_headers|response.addTrailers}
  */
 
-/**
- * Buffers written data in memory. This data will be flushed when either the uncork or end methods are called.
- * @method cork
- * @alias HttpDuplex.cork
- * @memberof HttpDuplex
- * @see uncork
- * @see {@link https://nodejs.org/api/stream.html#stream_writable_cork|stream.Writeable.cork}
- * @example
- * request.cork();
- * request.write('buffer data ');
- * request.write('before sending ');
- * request.uncork();
- */
-
 /**
  * Tells the server the response headers and body have been sent and that the message should be considered complete.
  * This MUST be called on every response.
@@ -439,15 +480,6 @@ module.exports = HttpDuplex;
  * request.setHeader('Set-Cookie', ['type=auth', 'language=javascript']);
  */
 
-/**
- * Flushes all data buffered since cork() was called.
- * @method uncork
- * @alias HttpDuplex.cork
- * @memberof HttpDuplex
- * @see cork
- * @see {@link https://nodejs.org/api/stream.html#stream_writable_uncork|stream.Writeable.uncork}
- */
-
 /**
  * Sends a chunk of the response body. This method may be called multiple times to provide successive parts of the
  * body.
@@ -476,23 +508,6 @@ module.exports = HttpDuplex;
  * {@link https://nodejs.org/api/http.html#http_event_checkcontinue|http.Server/checkContinue}
  */
 
-/**
- * Sends a response header to the client request. Must only be called one time and before calling response.end().
- * @method writeHead
- * @alias HttpDuplex.writeHead
- * @memberof HttpDuplex
- * @param {Number} statusCode 3-digit HTTP status code, like 404
- * @param {String} [statusMessage] An optional human readable status message to send with the status code
- * @param {Object} [headers] An object containing the response headers to send
- * @see {@link https://nodejs.org/api/http.html#http_response_writehead_statuscode_statusmessage_headers|response.writeHead}
- * @example var content = 'Under Construction...';
- * response.writeHead(200, {
- *     'Content-Length': Buffer.byteLength(content),
- *     'Content-Type': 'text/plain'
- * });
- * response.end(content);
- */
-
 /**
  * __Warning:__ This has been deprecated in node, __don't__ use it. Any apis that require this funtion should be
  * updated to use writeHead insted.
