Analytics app name/version overrides

jamesdaniels · jamesdaniels · commit 8a96469fa4f1 · 2019-10-05T01:32:49.000+01:00
diff --git a/addon/mixins/analytics-route.ts b/addon/mixins/analytics-route.ts
@@ -3,18 +3,21 @@ import { inject as service } from '@ember/service';
 import { get } from '@ember/object';
 
 export default Mixin.create({
+    analyticsAppName: null as string|null,
+    analyticsAppVersion: null as string|null,
     firebaseApp: service('firebase-app'),
     router: service('router'),
     init() {
         this._super(...arguments);
         const router = get(this, 'router');
         router.on('routeDidChange', () => {
             const firebase = get(this, 'firebaseApp');
-            const app_name = "Ember App";
-            const screen_name = router.currentRouteName || '';
+            const app_name = get(this, 'analyticsAppName') || 'Ember App';
+            const app_version = get(this, 'analyticsAppVersion') || undefined;
+            const screen_name = router.currentRouteName || undefined;
             const url = router.currentURL;
             firebase.analytics().then(analytics => {
-                analytics.logEvent("screen_view", { app_name, screen_name, url });
+                analytics.logEvent("screen_view", { app_name, screen_name, url, app_version });
             });
         })
     }
diff --git a/tests/dummy/app/routes/application.js b/tests/dummy/app/routes/application.js
@@ -1,4 +1,7 @@
 import AnalyticsRouteMixin from 'emberfire/mixins/analytics-route';
 import Route from '@ember/routing/route';
 
-export default Route.extend(AnalyticsRouteMixin);
+export default Route.extend(AnalyticsRouteMixin, {
+  analyticsAppName: 'Something, something, app',
+  analyticsAppVersion: '0'
+});
