FaithStudio
diff --git a/‎Assets/Editor/Tests/RenderloopTests/CullResultsTest.cs‎
Lines changed: 0 additions & 3 deletions b/‎Assets/Editor/Tests/RenderloopTests/CullResultsTest.cs‎
Lines changed: 0 additions & 3 deletions
diff --git a/‎Assets/Editor/Tests/RenderloopTests/RenderloopTestFixture.cs‎
Lines changed: 4 additions & 4 deletions b/‎Assets/Editor/Tests/RenderloopTests/RenderloopTestFixture.cs‎
Lines changed: 4 additions & 4 deletions
diff --git a/‎Assets/ScriptableRenderLoop/AdditionalLightData.cs‎
Lines changed: 3 additions & 5 deletions b/‎Assets/ScriptableRenderLoop/AdditionalLightData.cs‎
Lines changed: 3 additions & 5 deletions
diff --git a/‎Assets/ScriptableRenderLoop/ForwardRenderLoop/ForwardRenderLoop.cs‎
Lines changed: 3 additions & 6 deletions b/‎Assets/ScriptableRenderLoop/ForwardRenderLoop/ForwardRenderLoop.cs‎
Lines changed: 3 additions & 6 deletions
@@ -1,8 +1,5 @@
 using UnityEngine;
-using UnityEditor;
 using UnityEngine.Rendering;
-using System.Collections.Generic;
-using System.Linq;
 using NUnit.Framework;
 
 [TestFixture]
 
@@ -9,19 +9,19 @@
 public class RenderLoopTestFixture : MonoBehaviour
 {
     public delegate void TestDelegate(Camera camera, CullResults cullResults, RenderLoop renderLoop);
-    private static TestDelegate callback;
+    private static TestDelegate s_Callback;
 
     public static void Render(RenderLoopWrapper wrapper, Camera[] cameras, RenderLoop renderLoop)
     {
-        foreach (Camera camera in cameras)
+        foreach (var camera in cameras)
         {
             CullingParameters cullingParams;
             bool gotCullingParams = CullResults.GetCullingParameters(camera, out cullingParams);
             Assert.IsTrue(gotCullingParams);
 
             CullResults cullResults = CullResults.Cull(ref cullingParams, renderLoop);
 
-            callback(camera, cullResults, renderLoop);
+            s_Callback(camera, cullResults, renderLoop);
         }
 
         renderLoop.Submit();
@@ -34,7 +34,7 @@ public static void Run(TestDelegate renderCallback)
 
         var instance = camObject.AddComponent<RenderLoopWrapper>();
         instance.callback = Render;
-        callback = renderCallback;
+        s_Callback = renderCallback;
         instance.enabled = true;
 
         Transform t = camObject.transform;
 
@@ -1,15 +1,13 @@
-using System;
-
 namespace UnityEngine.ScriptableRenderLoop
 {
     //@TODO: We should continously move these values
     // into the engine when we can see them being generally useful
     [RequireComponent(typeof(Light))]
     public class AdditionalLightData : MonoBehaviour
     {
-        public const int defaultShadowResolution = 512;
+        public const int DefaultShadowResolution = 512;
 
-        public int shadowResolution = defaultShadowResolution;
+        public int shadowResolution = DefaultShadowResolution;
 
         [RangeAttribute(0.0F, 100.0F)]
         public float innerSpotPercent = 0.0F;
@@ -27,7 +25,7 @@ public static int GetShadowResolution(AdditionalLightData lightData)
             if (lightData != null)
                 return lightData.shadowResolution;
             else
-                return defaultShadowResolution;
+                return DefaultShadowResolution;
         }
     }
 }
@@ -1,8 +1,5 @@
-using UnityEngine;
 using UnityEngine.Rendering;
 using System;
-using System.Collections;
-using System.Collections.Generic;
 
 namespace UnityEngine.ScriptableRenderLoop
 {
@@ -62,7 +59,7 @@ void UpdateLightConstants(VisibleLight[] visibleLights, ref ShadowOutput shadow)
             var matWorldToShadow = new Matrix4x4[k_MaxLights * k_MaxShadowmapPerLights];
             var dirShadowSplitSpheres = new Vector4[k_MaxDirectionalSplit];
 
-            for (var nLight = 0; nLight < visibleLights.Length; nLight++)
+            for (int nLight = 0; nLight < visibleLights.Length; nLight++)
             {
                 numLightsIncludingTooMany++;
                 if (numLightsIncludingTooMany > k_MaxLights)
@@ -92,7 +89,7 @@ void UpdateLightConstants(VisibleLight[] visibleLights, ref ShadowOutput shadow)
 
                     if (hasShadows)
                     {
-                        for (var s = 0; s < k_MaxDirectionalSplit; ++s)
+                        for (int s = 0; s < k_MaxDirectionalSplit; ++s)
                         {
                             dirShadowSplitSpheres[s] = shadow.directionalShadowSplitSphereSqr[s];
                         }
@@ -127,7 +124,7 @@ void UpdateLightConstants(VisibleLight[] visibleLights, ref ShadowOutput shadow)
                 {
                     // Enable shadows
                     lightShadowIndex_lightParams[numLights].x = 1;
-                    for (var s = 0; s < shadow.GetShadowSliceCountLightIndex(nLight); ++s)
+                    for (int s = 0; s < shadow.GetShadowSliceCountLightIndex(nLight); ++s)
                     {
                         var shadowSliceIndex = shadow.GetShadowSliceIndex(nLight, s);
                         matWorldToShadow[numLights * k_MaxShadowmapPerLights + s] = shadow.shadowSlices[shadowSliceIndex].shadowTransform.transpose;
Original file line number	Diff line number	Diff line change
`@@ -1,15 +1,13 @@`
`1`		`-using System;`
`2`		`-`
`3`	`1`	`namespace UnityEngine.ScriptableRenderLoop`
`4`	`2`	`{`
`5`	`3`	`//@TODO: We should continously move these values`
`6`	`4`	`// into the engine when we can see them being generally useful`
`7`	`5`	`[RequireComponent(typeof(Light))]`
`8`	`6`	`public class AdditionalLightData : MonoBehaviour`
`9`	`7`	`{`
`10`		`- public const int defaultShadowResolution = 512;`
	`8`	`+ public const int DefaultShadowResolution = 512;`
`11`	`9`
`12`		`- public int shadowResolution = defaultShadowResolution;`
	`10`	`+ public int shadowResolution = DefaultShadowResolution;`
`13`	`11`
`14`	`12`	`[RangeAttribute(0.0F, 100.0F)]`
`15`	`13`	`public float innerSpotPercent = 0.0F;`
`@@ -27,7 +25,7 @@ public static int GetShadowResolution(AdditionalLightData lightData)`
`27`	`25`	`if (lightData != null)`
`28`	`26`	`return lightData.shadowResolution;`
`29`	`27`	`else`
`30`		`- return defaultShadowResolution;`
	`28`	`+ return DefaultShadowResolution;`
`31`	`29`	`}`
`32`	`30`	`}`
`33`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,5 @@`
`1`		`-using UnityEngine;`
`2`	`1`	`using UnityEngine.Rendering;`
`3`	`2`	`using System;`
`4`		`-using System.Collections;`
`5`		`-using System.Collections.Generic;`
`6`	`3`
`7`	`4`	`namespace UnityEngine.ScriptableRenderLoop`
`8`	`5`	`{`
`@@ -62,7 +59,7 @@ void UpdateLightConstants(VisibleLight[] visibleLights, ref ShadowOutput shadow)`
`62`	`59`	`var matWorldToShadow = new Matrix4x4[k_MaxLights * k_MaxShadowmapPerLights];`
`63`	`60`	`var dirShadowSplitSpheres = new Vector4[k_MaxDirectionalSplit];`
`64`	`61`
`65`		`- for (var nLight = 0; nLight < visibleLights.Length; nLight++)`
	`62`	`+ for (int nLight = 0; nLight < visibleLights.Length; nLight++)`
`66`	`63`	`{`
`67`	`64`	`numLightsIncludingTooMany++;`
`68`	`65`	`if (numLightsIncludingTooMany > k_MaxLights)`
`@@ -92,7 +89,7 @@ void UpdateLightConstants(VisibleLight[] visibleLights, ref ShadowOutput shadow)`
`92`	`89`
`93`	`90`	`if (hasShadows)`
`94`	`91`	`{`
`95`		`- for (var s = 0; s < k_MaxDirectionalSplit; ++s)`
	`92`	`+ for (int s = 0; s < k_MaxDirectionalSplit; ++s)`
`96`	`93`	`{`
`97`	`94`	`dirShadowSplitSpheres[s] = shadow.directionalShadowSplitSphereSqr[s];`
`98`	`95`	`}`
`@@ -127,7 +124,7 @@ void UpdateLightConstants(VisibleLight[] visibleLights, ref ShadowOutput shadow)`
`127`	`124`	`{`
`128`	`125`	`// Enable shadows`
`129`	`126`	`lightShadowIndex_lightParams[numLights].x = 1;`
`130`		`- for (var s = 0; s < shadow.GetShadowSliceCountLightIndex(nLight); ++s)`
	`127`	`+ for (int s = 0; s < shadow.GetShadowSliceCountLightIndex(nLight); ++s)`
`131`	`128`	`{`
`132`	`129`	`var shadowSliceIndex = shadow.GetShadowSliceIndex(nLight, s);`
`133`	`130`	`matWorldToShadow[numLights * k_MaxShadowmapPerLights + s] = shadow.shadowSlices[shadowSliceIndex].shadowTransform.transpose;`