Move supports_sane_rowcount_returning = False to dialect level

gordthompson · gordthompson · commit cc97dade0de0 · 2020-05-11T14:44:37.000-06:00
Fixes: sqlalchemy#5321 Change-Id: Id83e98e9013818424c133297a850746302633158
diff --git a/doc/build/changelog/unreleased_13/5321.rst b/doc/build/changelog/unreleased_13/5321.rst
@@ -0,0 +1,7 @@
+.. change::
+    :tags: change, mssql
+    :tickets: 5321
+
+    Moved the ``supports_sane_rowcount_returning = False`` requirement from
+    the ``PyODBCConnector`` level to the ``MSDialect_pyodbc`` since pyodbc
+    does work properly in some circumstances.
diff --git a/lib/sqlalchemy/connectors/pyodbc.py b/lib/sqlalchemy/connectors/pyodbc.py
@@ -14,7 +14,8 @@
 class PyODBCConnector(Connector):
     driver = "pyodbc"
 
-    supports_sane_rowcount_returning = False
+    # this is no longer False for pyodbc in general
+    supports_sane_rowcount_returning = True
     supports_sane_multi_rowcount = False
 
     supports_unicode_statements = True
diff --git a/lib/sqlalchemy/dialects/mssql/pyodbc.py b/lib/sqlalchemy/dialects/mssql/pyodbc.py
@@ -314,6 +314,9 @@ def post_exec(self):
 
 class MSDialect_pyodbc(PyODBCConnector, MSDialect):
 
+    # mssql still has problems with this on Linux
+    supports_sane_rowcount_returning = False
+
     execution_ctx_cls = MSExecutionContext_pyodbc
 
     colspecs = util.update_copy(
