fix: added pool_recycle option to create_engine (#12)

EXPEbdodla · Bhargav Dodla · web-flow · commit 8a4c1912bd78 · 2023-07-31T16:25:17.000-07:00
Co-authored-by: Bhargav Dodla &lt;bdodla@expediagroup.com&gt;
diff --git a/sdk/python/feast/infra/registry/sql.py b/sdk/python/feast/infra/registry/sql.py
@@ -202,7 +202,11 @@ def __init__(
         repo_path: Optional[Path],
     ):
         assert registry_config is not None, "SqlRegistry needs a valid registry_config"
-        self.engine: Engine = create_engine(registry_config.path, echo=False)
+        # pool_recycle will recycle connections after the given number of seconds has passed
+        # This is to avoid automatic disconnections when no activity is detected on connection
+        self.engine: Engine = create_engine(
+            registry_config.path, echo=False, pool_recycle=3600
+        )
         metadata.create_all(self.engine)
         self.cached_registry_proto = self.proto()
         proto_registry_utils.init_project_metadata(self.cached_registry_proto, project)
