From 547976242c8450e169bd49e3e724dc58a220ed89 Mon Sep 17 00:00:00 2001 From: Pasu Chan Chak Shing Date: Fri, 18 May 2018 11:00:48 +0800 Subject: [PATCH 1/2] Retry if selenium navigation test fail --- test/selenium/test_navigation.py | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/test/selenium/test_navigation.py b/test/selenium/test_navigation.py index fb225ac7b504..318b5a87f2df 100644 --- a/test/selenium/test_navigation.py +++ b/test/selenium/test_navigation.py @@ -9,7 +9,16 @@ class TestNavigation(ExtensionTestCase): def test_redirect(self): - self.driver.get(kittens_url) + num_retries = 5 + + + for i in range(0, num_retries): + self.driver.get(kittens_url) + + # retry if assertions fail until num_retries reached + if not self.driver.current_url.startswith('https:') and i > num_retries - 1: + self.assertTrue(self.driver.current_url.startswith('https')) + self.assertTrue(self.driver.current_url.startswith('https')) def test_no_redirect_when_disabled(self): From 34d3b5af574b47b25bcdfaf9f7886611dd9b1ca8 Mon Sep 17 00:00:00 2001 From: Pasu Chan Chak Shing Date: Fri, 18 May 2018 11:13:47 +0800 Subject: [PATCH 2/2] Update test_navigation.py --- test/selenium/test_navigation.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/selenium/test_navigation.py b/test/selenium/test_navigation.py index 318b5a87f2df..4384b1b6c2fb 100644 --- a/test/selenium/test_navigation.py +++ b/test/selenium/test_navigation.py @@ -1,3 +1,4 @@ +import time import unittest from util import ExtensionTestCase @@ -11,13 +12,14 @@ class TestNavigation(ExtensionTestCase): def test_redirect(self): num_retries = 5 - for i in range(0, num_retries): self.driver.get(kittens_url) # retry if assertions fail until num_retries reached if not self.driver.current_url.startswith('https:') and i > num_retries - 1: - self.assertTrue(self.driver.current_url.startswith('https')) + self.assertTrue(self.driver.current_url.startswith('https:')) + + time.sleep(3) self.assertTrue(self.driver.current_url.startswith('https'))