I think that I can confirm @koops76 and @Bisaloo 's observations. Given a tabId, for each request, we look for rulesets which have matching target. Among these ruleset, if it is active (not default_off), we show it as an entry of "Stable rules"; otherwise, it is regarded as "Experimental rules". So, whether or not these rulesets make a redirection is not taken into account.

~~While this issue shouldn't be too difficult to fix~~, I am not sure what is the expected behavior for those default_off rulesets? By definition, they do not make redirections until an user activate them. However, if they do not show up, it might not be possible for non-technical user to activate these rulesets.

Lines 285 to 290 in e958e4b

    
           for (let ruleset of potentiallyApplicable) { 
        
             activeRulesets.addRulesetToTab(details.tabId, ruleset); 
        
             if (ruleset.active && !newuristr) { 
        
               newuristr = ruleset.apply(canonical_url); 
        
             } 
        
           }

Possible fix (not tested)

for (let ruleset of potentiallyApplicable) {
  newuristr = ruleset.apply(canonical_url); // apply() for each ruleset is very inefficient
  if(newuristr) {
    activeRulesets.addRulesetToTab(details.tabId, ruleset);
  }
}

	for (let ruleset of potentiallyApplicable) {
	activeRulesets.addRulesetToTab(details.tabId, ruleset);
	if (ruleset.active && !newuristr) {
	newuristr = ruleset.apply(canonical_url);
	}
	}

Uh oh!

Only show a ruleset if at least one redirection took place. #13412

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions