Add ESLint Travis task (#10897)

koops76 · Hainish · commit dba80b32f26f · 2017-07-06T18:07:44.000-07:00
diff --git a/.travis.yml b/.travis.yml
@@ -5,6 +5,7 @@ services:
 script:
   - test/travis.sh
 env:
+  - TEST=eslint
   - TEST=firefox FIREFOX=firefox-dev
   - TEST=firefox FIREFOX=firefox-latest
   - TEST=firefox FIREFOX=firefox-esr-latest
diff --git a/chromium/.eslintrc.json b/chromium/.eslintrc.json
@@ -0,0 +1,8 @@
+{
+    "env": {
+        "browser": true,
+        "commonjs": true,
+        "es6": true,
+        "node": true
+    }
+}
diff --git a/chromium/.gitignore b/chromium/.gitignore
@@ -1 +1 @@
-updates.xml
+updates.xml
diff --git a/test/travis.sh b/test/travis.sh
@@ -42,11 +42,18 @@ set -e
 
 if ! $ONLY_RULESETS_CHANGED; then
   echo >&2 "Core code changes have been made."
+
+  if [ "$TEST" == "eslint" ]; then
+    echo >&2 "Running ESLint."
+    docker run --rm -ti -v $(pwd):/opt node bash -c "cd /opt/utils/eslint && npm install && ./node_modules/.bin/eslint ../../chromium"
+  fi
+
   if [ "$TEST" == "firefox" ]; then
     echo >&2 "Running firefox test suite."
     docker_build
     docker run --rm -ti -v $(pwd):/opt -e FIREFOX=/$FIREFOX/firefox/firefox httpse bash -c "test/firefox.sh"
   fi
+
   if [ "$TEST" == "chromium" ]; then
     echo >&2 "Running chromium test suite."
     docker_build
@@ -66,7 +73,6 @@ if [ "$RULESETS_CHANGED" ]; then
     docker run --rm -ti -v $(pwd):/opt httpse bash -c "test/rules.sh"
   fi
 
-
   if [ "$TEST" == "fetch" ]; then
     echo >&2 "Testing test URLs in all changed rulesets."
     docker_build
diff --git a/utils/eslint/.gitignore b/utils/eslint/.gitignore
@@ -0,0 +1 @@
+node_modules
diff --git a/utils/eslint/package.json b/utils/eslint/package.json
@@ -0,0 +1,5 @@
+{
+  "devDependencies": {
+    "eslint": "^4.1.1"
+  }
+}

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +{
 +  "devDependencies": {
 +    "eslint": "^4.1.1"
 +  }
 +}