Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Commit d80ac96

Browse files
authored
Update Pull Request Template to be More Helpful (#19688)
Updating PR template to be more helpful * Amend from maintainer's input - Remove redundant wording
1 parent a7bb6a0 commit d80ac96

File tree

3 files changed

+11
-44
lines changed

3 files changed

+11
-44
lines changed

.github/PULL_REQUEST_TEMPLATE/existing_contributors.md

Lines changed: 0 additions & 10 deletions
This file was deleted.

.github/PULL_REQUEST_TEMPLATE/pull_request_template.md

Lines changed: 0 additions & 13 deletions
This file was deleted.

.github/pull_request_template.md

Lines changed: 11 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,16 @@
1-
***Delete section if irrelevant***
1+
Fixes #(issue)
22

3-
### List related PRs if any
3+
## Type of change
44

5-
- pr link
5+
- [ ] Bug fix (non-breaking change which fixes an issue)
6+
- [ ] New feature (non-breaking change which adds functionality)
7+
- [ ] Refactoring existing code
8+
- [ ] New Ruleset
9+
- [ ] Existing Ruleset
610

7-
### List related issues if any
11+
## For Rulesets: Testing
812

9-
- issue link
13+
- [ ] Travis CI completed without errors (triggered upon pull request)
1014

11-
***May delete note after reading***
12-
13-
### Note to contributor:
14-
Thank you for contributing! If this is a new ruleset and your first time contributing, congratulations! There will be some tests ran through our continuous integration in Travis. For example, checking for duplicate hosts, problematic hosts, etc. in the ruleset file. You will see this testing begin when you open this pull request.
15-
16-
If this is not your first time and you have open PRs that have not been closed or merged, please revisit them by searching: `https://github.com/EFForg/https-everywhere/issues?q=is%3Aopen+assignee%3A[yourusernamehere]`. If there is something not being addressed by other maintainers or a project lead, link them to the PR with your question. Thank you for your patience.
17-
18-
More helpful filters in Pull Request search:
19-
- Changes requested:
20-
`is:pr is:open type:pr review:changes_requested author:[your username]`
21-
- Updated from specific date:
22-
`is:pr updated:>yyyy-mm-dd`
23-
- Merged PRs:
24-
`is:pr is:merged author:[your username]`
25-
- Approved PRs:
26-
`is:pr review:approved author:[your username]`
15+
## Existing Contributors
16+
If you have open PRs that have not been closed or merged, please revisit them by searching: `https://github.com/EFForg/https-everywhere/issues?q=is%3Aopen+assignee%3A[yourusernamehere]`.

0 commit comments

Comments
 (0)