Fix for URL sanitization in wp_kses_bad_protocol_once().

desrosj · desrosj · commit fafead9bef48 · 2019-09-04T18:21:38.000Z
Merges [45997] to the 4.5 branch. Props irsdl, sstoqnov, whyisjake. git-svn-id: https://develop.svn.wordpress.org/branches/4.5@46009 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/kses.php b/src/wp-includes/kses.php
@@ -1396,6 +1396,7 @@ function wp_kses_html_error($string) {
  * @return string Sanitized content
  */
 function wp_kses_bad_protocol_once($string, $allowed_protocols, $count = 1 ) {
+	$string  = preg_replace( '/(&#0*58(?![;0-9])|&#x0*3a(?![;a-f0-9]))/i', '$1;', $string );
 	$string2 = preg_split( '/:|&#0*58;|&#x0*3a;/i', $string, 2 );
 	if ( isset($string2[1]) && ! preg_match('%/\?%', $string2[0]) ) {
 		$string = trim( $string2[1] );
diff --git a/tests/phpunit/tests/kses.php b/tests/phpunit/tests/kses.php
@@ -137,6 +137,8 @@ function test_wp_kses_bad_protocol() {
 			'javascript&#0000058alert(1)//?:',
 			'feed:javascript:alert(1)',
 			'feed:javascript:feed:javascript:feed:javascript:alert(1)',
+			'javascript&#58alert(1)',
+			'javascript&#x3ax=1;alert(1)',
 		);
 		foreach ( $bad as $k => $x ) {
 			$result = wp_kses_bad_protocol( wp_kses_normalize_entities( $x ), wp_allowed_protocols() );
@@ -146,10 +148,23 @@ function test_wp_kses_bad_protocol() {
 					case 12:
 						$this->assertEquals( str_replace( '&', '&amp;', $x ), $result );
 						break;
-					case 22: $this->assertEquals( 'javascript&amp;#0000058alert(1);', $result ); break;
-					case 23: $this->assertEquals( 'javascript&amp;#0000058alert(1)//?:', $result ); break;
-					case 24: $this->assertEquals( 'feed:alert(1)', $result ); break;
-					default: $this->fail( "wp_kses_bad_protocol failed on $x. Result: $result" );
+					case 22:
+						$this->assertEquals( 'javascript&amp;#0000058alert(1);', $result );
+						break;
+					case 23:
+						$this->assertEquals( 'javascript&amp;#0000058alert(1)//?:', $result );
+						break;
+					case 24:
+						$this->assertEquals( 'feed:alert(1)', $result );
+						break;
+					case 26:
+						$this->assertEquals( 'javascript&amp;#58alert(1)', $result );
+						break;
+					case 27:
+						$this->assertEquals( 'javascript&amp;#x3ax=1;alert(1)', $result );
+						break;
+					default:
+						$this->fail( "wp_kses_bad_protocol failed on $k, $x. Result: $result" );
 				}
 			}
 		}
