Upgrade/Install: Keep search engine checkbox value when reloading the Install screen.

audrasjb · audrasjb · commit f53188ffff12 · 2022-09-27T10:35:08.000Z
This changeset ensures the value of the search engine checkbox is not reset to its default value when a faulty form is sent in the Install screen. Props ramon-fincken, audrasjb, whaze, rafiahmedd, khokansardar, costdev, ankit-k-gupta. Fixes #55900. git-svn-id: https://develop.svn.wordpress.org/trunk@54326 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-admin/install.php b/src/wp-admin/install.php
@@ -96,7 +96,7 @@ function display_setup_form( $error = null ) {
 	// Ensure that sites appear in search engines by default.
 	$blog_public = 1;
 	if ( isset( $_POST['weblog_title'] ) ) {
-		$blog_public = isset( $_POST['blog_public'] );
+		$blog_public = isset( $_POST['blog_public'] ) ? (int) $_POST['blog_public'] : $blog_public;
 	}
 
 	$weblog_title = isset( $_POST['weblog_title'] ) ? trim( wp_unslash( $_POST['weblog_title'] ) ) : '';

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ function display_setup_form( $error = null ) {`
`96`	`96`	`// Ensure that sites appear in search engines by default.`
`97`	`97`	`$blog_public = 1;`
`98`	`98`	`if ( isset( $_POST['weblog_title'] ) ) {`
`99`		`- $blog_public = isset( $_POST['blog_public'] );`
	`99`	`+ $blog_public = isset( $_POST['blog_public'] ) ? (int) $_POST['blog_public'] : $blog_public;`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`$weblog_title = isset( $_POST['weblog_title'] ) ? trim( wp_unslash( $_POST['weblog_title'] ) ) : '';`