Upgrade/Install: Introduce wp_disallow_file_mods() helper function.

swissspidy · swissspidy · commit f44a9eba4e1b · 2017-04-07T14:35:39.000Z
This is a wrapper around the checks for the `DISALLOW_FILE_MODS` constant to determine whether file modifications are disallowed. Props MaximeCulea. Fixes #38673. git-svn-id: https://develop.svn.wordpress.org/trunk@40394 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-admin/includes/class-wp-automatic-updater.php b/src/wp-admin/includes/class-wp-automatic-updater.php
@@ -31,7 +31,7 @@ class WP_Automatic_Updater {
 	 */
 	public function is_disabled() {
 		// Background updates are disabled if you don't want file changes.
-		if ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS )
+		if ( wp_disallow_file_mods( 'automatic_updater' ) )
 			return true;
 
 		if ( wp_installing() )
diff --git a/src/wp-admin/includes/dashboard.php b/src/wp-admin/includes/dashboard.php
@@ -1152,7 +1152,7 @@ function wp_dashboard_primary() {
 		)
 	);
 
-	if ( ( ! defined( 'DISALLOW_FILE_MODS' ) || ! DISALLOW_FILE_MODS ) && ( ! is_multisite() && is_blog_admin() && current_user_can( 'install_plugins' ) ) || ( is_network_admin() && current_user_can( 'manage_network_plugins' ) && current_user_can( 'install_plugins' ) ) ) {
+	if ( ( ! wp_disallow_file_mods( 'dashboard_widget' ) ) && ( ! is_multisite() && is_blog_admin() && current_user_can( 'install_plugins' ) ) || ( is_network_admin() && current_user_can( 'manage_network_plugins' ) && current_user_can( 'install_plugins' ) ) ) {
 		$feeds['plugins'] = array(
 			'link'         => '',
 			'url'          => array(
diff --git a/src/wp-admin/includes/translation-install.php b/src/wp-admin/includes/translation-install.php
@@ -202,7 +202,7 @@ function wp_download_language_pack( $download ) {
 		return $download;
 	}
 
-	if ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS ) {
+	if ( wp_disallow_file_mods( 'download_language_pack' ) ) {
 		return false;
 	}
 
@@ -245,7 +245,7 @@ function wp_download_language_pack( $download ) {
  * @return bool Returns true on success, false on failure.
  */
 function wp_can_install_language_pack() {
-	if ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS ) {
+	if ( wp_disallow_file_mods( 'can_install_language_pack' ) ) {
 		return false;
 	}
 
diff --git a/src/wp-includes/capabilities.php b/src/wp-includes/capabilities.php
@@ -362,7 +362,7 @@ function map_meta_cap( $cap, $user_id ) {
 		// Disallow the file editors.
 		if ( defined( 'DISALLOW_FILE_EDIT' ) && DISALLOW_FILE_EDIT )
 			$caps[] = 'do_not_allow';
-		elseif ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS )
+		elseif ( wp_disallow_file_mods( 'capability_edit_themes' ) )
 			$caps[] = 'do_not_allow';
 		elseif ( is_multisite() && ! is_super_admin( $user_id ) )
 			$caps[] = 'do_not_allow';
@@ -380,7 +380,7 @@ function map_meta_cap( $cap, $user_id ) {
 	case 'update_core':
 		// Disallow anything that creates, deletes, or updates core, plugin, or theme files.
 		// Files in uploads are excepted.
-		if ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS ) {
+		if ( wp_disallow_file_mods( 'capability_update_core' ) ) {
 			$caps[] = 'do_not_allow';
 		} elseif ( is_multisite() && ! is_super_admin( $user_id ) ) {
 			$caps[] = 'do_not_allow';
diff --git a/src/wp-includes/load.php b/src/wp-includes/load.php
@@ -1072,3 +1072,23 @@ function wp_doing_ajax() {
 function is_wp_error( $thing ) {
 	return ( $thing instanceof WP_Error );
 }
+
+/**
+ * Determines whether file modifications are disallowed.
+ *
+ * @since 4.8.0
+ *
+ * @param string $context The usage context.
+ * @return bool True if file modification is disallowed, false otherwise.
+ */
+function wp_disallow_file_mods( $context ) {
+	/**
+	 * Filters whether file modifications are disallowed.
+	 *
+	 * @since 4.8.0
+	 *
+	 * @param bool   $disllow_file_mods Whether file modifications are disallowed.
+	 * @param string $context           The usage context.
+	 */
+	return apply_filters( 'disallow_file_mods' , defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS, $context );
+}

Original file line number	Diff line number	Diff line change
`@@ -1152,7 +1152,7 @@ function wp_dashboard_primary() {`
`1152`	`1152`	`)`
`1153`	`1153`	`);`
`1154`	`1154`
`1155`		`- if ( ( ! defined( 'DISALLOW_FILE_MODS' ) \|\| ! DISALLOW_FILE_MODS ) && ( ! is_multisite() && is_blog_admin() && current_user_can( 'install_plugins' ) ) \|\| ( is_network_admin() && current_user_can( 'manage_network_plugins' ) && current_user_can( 'install_plugins' ) ) ) {`
	`1155`	`+ if ( ( ! wp_disallow_file_mods( 'dashboard_widget' ) ) && ( ! is_multisite() && is_blog_admin() && current_user_can( 'install_plugins' ) ) \|\| ( is_network_admin() && current_user_can( 'manage_network_plugins' ) && current_user_can( 'install_plugins' ) ) ) {`
`1156`	`1156`	`$feeds['plugins'] = array(`
`1157`	`1157`	`'link' => '',`
`1158`	`1158`	`'url' => array(`
Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,7 @@ function wp_download_language_pack( $download ) {`
`202`	`202`	`return $download;`
`203`	`203`	`}`
`204`	`204`
`205`		`- if ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS ) {`
	`205`	`+ if ( wp_disallow_file_mods( 'download_language_pack' ) ) {`
`206`	`206`	`return false;`
`207`	`207`	`}`
`208`	`208`
`@@ -245,7 +245,7 @@ function wp_download_language_pack( $download ) {`
`245`	`245`	`* @return bool Returns true on success, false on failure.`
`246`	`246`	`*/`
`247`	`247`	`function wp_can_install_language_pack() {`
`248`		`- if ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS ) {`
	`248`	`+ if ( wp_disallow_file_mods( 'can_install_language_pack' ) ) {`
`249`	`249`	`return false;`
`250`	`250`	`}`
`251`	`251`