Bump the autosave re-enable delay to 5 seconds, makes sure we manually re-enable the buttons on ajax success, and visually dim the disabled buttons for some UI feedback. Props mdawaffe. fixes WordPress#6707 for trunk

ryanboren · ryanboren · commit eae779df32b9 · 2008-04-25T00:32:29.000Z
git-svn-id: https://develop.svn.wordpress.org/trunk@7813 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/wp-admin/css/colors-classic.css b/wp-admin/css/colors-classic.css
@@ -192,6 +192,10 @@ ul.widget-control-list .sorthelper {
 	border-color: #a3a3a3;
 }
 
+.button[disabled], .button:disabled {
+	background-color: #999;
+}
+
 .tablenav .button-secondary {
 	border-color: #5396c5;
 }
diff --git a/wp-admin/css/colors-fresh.css b/wp-admin/css/colors-fresh.css
@@ -188,6 +188,10 @@ ul.widget-control-list .sorthelper {
 	border-color: #80b5d0;
 }
 
+.button[disabled], .button:disabled {
+	background-color: #999;
+}
+
 .submit input:hover, .button:hover, #edit-slug-buttons a.save:hover {
 	border-color: #535353;
 }
diff --git a/wp-includes/js/autosave.js b/wp-includes/js/autosave.js
@@ -56,13 +56,14 @@ function autosave_saved_new(response) {
 	if ( res && res.responses.length && !res.errors ) {
 		var tempID = jQuery('#post_ID').val();
 		var postID = parseInt( res.responses[0].id );
-		autosave_update_post_ID( postID );
+		autosave_update_post_ID( postID ); // disabled form buttons are re-enabled here
 		if ( tempID < 0 && postID > 0) // update media buttons
 			jQuery('#media-buttons a').each(function(){
 				this.href = this.href.replace(tempID, postID);
 			});
+	} else {
+		autosave_enable_buttons(); // re-enable disabled form buttons
 	}
-	autosave_enable_buttons(); // re-enable disabled form buttons
 }
 
 function autosave_update_post_ID( postID ) {
@@ -78,6 +79,7 @@ function autosave_update_post_ID( postID ) {
 			post_type: jQuery('#post_type').val()
 		}, function(html) {
 			jQuery('#_wpnonce').val(html);
+			autosave_enable_buttons(); // re-enable disabled form buttons
 		});
 		jQuery('#hiddenaction').val('editpost');
 	}
@@ -127,7 +129,7 @@ function autosave_enable_buttons() {
 
 function autosave_disable_buttons() {
 	jQuery("#submitpost :button:enabled, #submitpost :submit:enabled").attr('disabled', 'disabled');
-	setTimeout(autosave_enable_buttons, 1000); // Re-enable 1 sec later.  Just gives autosave a head start to avoid collisions.
+	setTimeout(autosave_enable_buttons, 5000); // Re-enable 5 sec later.  Just gives autosave a head start to avoid collisions.
 }
 
 var autosave = function() {
diff --git a/wp-includes/script-loader.php b/wp-includes/script-loader.php
@@ -47,7 +47,7 @@ function default_scripts() {
 			'broken' => __('An unidentified error has occurred.')
 		) );
 
-		$this->add( 'autosave', '/wp-includes/js/autosave.js', array('schedule', 'wp-ajax-response'), '20080422' );
+		$this->add( 'autosave', '/wp-includes/js/autosave.js', array('schedule', 'wp-ajax-response'), '20080424' );
 
 		$this->add( 'wp-ajax', '/wp-includes/js/wp-ajax.js', array('prototype'), '20070306');
 		$this->localize( 'wp-ajax', 'WPAjaxL10n', array(

Original file line number	Diff line number	Diff line change
`@@ -192,6 +192,10 @@ ul.widget-control-list .sorthelper {`
`192`	`192`	`border-color: #a3a3a3;`
`193`	`193`	`}`
`194`	`194`
	`195`	`+.button[disabled], .button:disabled {`
	`196`	`+ background-color: #999;`
	`197`	`+}`
	`198`	`+`
`195`	`199`	`.tablenav .button-secondary {`
`196`	`200`	`border-color: #5396c5;`
`197`	`201`	`}`
Original file line number	Diff line number	Diff line change
`@@ -188,6 +188,10 @@ ul.widget-control-list .sorthelper {`
`188`	`188`	`border-color: #80b5d0;`
`189`	`189`	`}`
`190`	`190`
	`191`	`+.button[disabled], .button:disabled {`
	`192`	`+ background-color: #999;`
	`193`	`+}`
	`194`	`+`
`191`	`195`	`.submit input:hover, .button:hover, #edit-slug-buttons a.save:hover {`
`192`	`196`	`border-color: #535353;`
`193`	`197`	`}`