Date/Time: Eliminate use of date_default_timezone_set() for determining DST status on General Options screen.

SergeyBiryukov · SergeyBiryukov · commit e9fc71bbbe8b · 2019-06-20T14:10:44.000Z
Time calculations should not need to rely on manipulating global PHP configuration state. Props Rarst. Fixes #46483. git-svn-id: https://develop.svn.wordpress.org/trunk@45556 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-admin/options-general.php b/src/wp-admin/options-general.php
@@ -252,10 +252,10 @@
 <p class="timezone-info">
 <span>
 	<?php
-	// Set TZ so localtime works.
-	date_default_timezone_set( $tzstring );
-	$now = localtime( time(), true );
-	if ( $now['tm_isdst'] ) {
+	$now = new DateTime( 'now', new DateTimeZone( $tzstring ) );
+	$dst = (bool) $now->format( 'I' );
+
+	if ( $dst ) {
 		_e( 'This timezone is currently in daylight saving time.' );
 	} else {
 		_e( 'This timezone is currently in standard time.' );
@@ -296,8 +296,6 @@
 			_e( 'This timezone does not observe daylight saving time.' );
 		}
 	}
-	// Set back to UTC.
-	date_default_timezone_set( 'UTC' );
 	?>
 	</span>
 </p>
