Users: Allow to create users without sending an email to the new user.

ocean90 · ocean90 · commit daa3fe4d266d · 2015-11-25T22:37:35.000Z
This adds a checkbox to `wp-admin/user-new.php` to prevent sending an email with the username and a password reset link to the new user. Restores the behavior of pre-4.3. Fixes #33504. Props tharsheblows, SergeyBiryukov, DrewAPicture, ocean90. git-svn-id: https://develop.svn.wordpress.org/trunk@35742 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-admin/includes/user.php b/src/wp-admin/includes/user.php
@@ -176,14 +176,18 @@ function edit_user( $user_id = 0 ) {
 		$user_id = wp_update_user( $user );
 	} else {
 		$user_id = wp_insert_user( $user );
+		$notify  = isset( $_POST['send_user_notification'] ) ? 'both' : 'admin';
+
 		/**
 		  * Fires after a new user has been created.
 		  *
 		  * @since 4.4.0
 		  *
-		  * @param int $user_id ID of the newly created user.
+		  * @param int    $user_id ID of the newly created user.
+		  * @param string $notify  Type of notification that should happen. See {@see wp_send_new_user_notifications()}
+		  *                        for more information on possible values.
 		  */
-		do_action( 'edit_user_created_user', $user_id );
+		do_action( 'edit_user_created_user', $user_id, $notify );
 	}
 	return $user_id;
 }
diff --git a/src/wp-admin/user-new.php b/src/wp-admin/user-new.php
@@ -368,7 +368,7 @@
 $new_user_email = $creating && isset( $_POST['email'] ) ? wp_unslash( $_POST['email'] ) : '';
 $new_user_uri = $creating && isset( $_POST['url'] ) ? wp_unslash( $_POST['url'] ) : '';
 $new_user_role = $creating && isset( $_POST['role'] ) ? wp_unslash( $_POST['role'] ) : '';
-$new_user_send_password = $creating && isset( $_POST['send_password'] ) ? wp_unslash( $_POST['send_password'] ) : true;
+$new_user_send_notification = $creating && ! isset( $_POST['send_user_notification'] ) ? false : true;
 $new_user_ignore_pass = $creating && isset( $_POST['noconfirmation'] ) ? wp_unslash( $_POST['noconfirmation'] ) : '';
 
 ?>
@@ -418,7 +418,6 @@
 				</button>
 				<div style="display:none" id="pass-strength-result" aria-live="polite"></div>
 			</div>
-			<p><span class="description"><?php _e( 'A password reset link will be sent to the user via email.' ); ?></span></p>
 		</td>
 	</tr>
 	<tr class="form-field form-required user-pass2-wrap hide-if-js">
@@ -436,6 +435,10 @@
 			</label>
 		</td>
 	</tr>
+	<tr>
+		<th scope="row"><?php _e( 'Send User Notification' ) ?></th>
+		<td><label for="send_user_notification"><input type="checkbox" name="send_user_notification" id="send_user_notification" value="1" <?php checked( $new_user_send_notification ); ?> /> <?php _e( 'Send the new user an email about their account.' ); ?></label></td>
+	</tr>
 <?php } // !is_multisite ?>
 	<tr class="form-field">
 		<th scope="row"><label for="role"><?php _e('Role'); ?></label></th>
diff --git a/src/wp-includes/default-filters.php b/src/wp-includes/default-filters.php
@@ -357,7 +357,7 @@
 add_action( 'comment_post', 'wp_new_comment_notify_postauthor' );
 add_action( 'after_password_reset', 'wp_password_change_notification' );
 add_action( 'register_new_user',      'wp_send_new_user_notifications' );
-add_action( 'edit_user_created_user', 'wp_send_new_user_notifications' );
+add_action( 'edit_user_created_user', 'wp_send_new_user_notifications', 10, 2 );
 
 // REST API actions.
 add_action( 'init',          'rest_api_init' );
diff --git a/src/wp-includes/user.php b/src/wp-includes/user.php
@@ -2198,10 +2198,12 @@ function register_new_user( $user_login, $user_email ) {
  *
  * @since 4.4.0
  *
- * @param int $user_id ID of the newly created user.
+ * @param int    $user_id ID of the newly created user.
+ * @param string $notify  Optional. Type of notification that should happen. Accepts 'admin' or an empty string
+ *                        (admin only), or 'both' (admin and user). Default 'both'.
  */
-function wp_send_new_user_notifications( $user_id ) {
-	wp_new_user_notification( $user_id, null, 'both' );
+function wp_send_new_user_notifications( $user_id, $notify = 'both' ) {
+	wp_new_user_notification( $user_id, null, $notify );
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -176,14 +176,18 @@ function edit_user( $user_id = 0 ) {`
`176`	`176`	`$user_id = wp_update_user( $user );`
`177`	`177`	`} else {`
`178`	`178`	`$user_id = wp_insert_user( $user );`
	`179`	`+ $notify = isset( $_POST['send_user_notification'] ) ? 'both' : 'admin';`
	`180`	`+`
`179`	`181`	`/**`
`180`	`182`	`* Fires after a new user has been created.`
`181`	`183`	`*`
`182`	`184`	`* @since 4.4.0`
`183`	`185`	`*`
`184`		`- * @param int $user_id ID of the newly created user.`
	`186`	`+ * @param int $user_id ID of the newly created user.`
	`187`	`+ * @param string $notify Type of notification that should happen. See {@see wp_send_new_user_notifications()}`
	`188`	`+ * for more information on possible values.`
`185`	`189`	`*/`
`186`		`- do_action( 'edit_user_created_user', $user_id );`
	`190`	`+ do_action( 'edit_user_created_user', $user_id, $notify );`
`187`	`191`	`}`
`188`	`192`	`return $user_id;`
`189`	`193`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2198,10 +2198,12 @@ function register_new_user( $user_login, $user_email ) {`
`2198`	`2198`	`*`
`2199`	`2199`	`* @since 4.4.0`
`2200`	`2200`	`*`
`2201`		`- * @param int $user_id ID of the newly created user.`
	`2201`	`+ * @param int $user_id ID of the newly created user.`
	`2202`	`+ * @param string $notify Optional. Type of notification that should happen. Accepts 'admin' or an empty string`
	`2203`	`+ * (admin only), or 'both' (admin and user). Default 'both'.`
`2202`	`2204`	`*/`
`2203`		`-function wp_send_new_user_notifications( $user_id ) {`
`2204`		`- wp_new_user_notification( $user_id, null, 'both' );`
	`2205`	`+function wp_send_new_user_notifications( $user_id, $notify = 'both' ) {`
	`2206`	`+ wp_new_user_notification( $user_id, null, $notify );`
`2205`	`2207`	`}`
`2206`	`2208`
`2207`	`2209`	`/**`