Skip to content

Commit d399bcc

Browse files
felixarntzfelixarntz
committed
Role/Capability: Rename upgrade_php capability to more suitable update_php.
This brings the name in line with user-facing language and similar names of existing related capabilities. Since the capability has not been part of any WordPress release, it can be renamed without any backward-compatibility implications. Also missing props benhuberman for [43006]. Fixes #44457. git-svn-id: https://develop.svn.wordpress.org/trunk@43381 602fd350-edb4-49c9-b593-d223f7449a82
1 parent efe9a3e commit d399bcc

3 files changed

Lines changed: 58 additions & 58 deletions

File tree

‎src/wp-admin/includes/dashboard.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ function wp_dashboard_setup() {
3737

3838
// PHP Version.
3939
$response = wp_check_php_version();
40-
if ( $response && isset( $response['is_acceptable'] ) && ! $response['is_acceptable'] && current_user_can( 'upgrade_php' ) ) {
40+
if ( $response && isset( $response['is_acceptable'] ) && ! $response['is_acceptable'] && current_user_can( 'update_php' ) ) {
4141
add_filter( 'postbox_classes_dashboard_dashboard_php_nag', 'dashboard_php_nag_class' );
4242
wp_add_dashboard_widget( 'dashboard_php_nag', __( 'PHP Update Required' ), 'wp_dashboard_php_nag' );
4343
}

‎src/wp-includes/capabilities.php‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -554,7 +554,7 @@ function map_meta_cap( $cap, $user_id ) {
554554
$caps[] = 'manage_options';
555555
}
556556
break;
557-
case 'upgrade_php':
557+
case 'update_php':
558558
if ( is_multisite() && ! is_super_admin( $user_id ) ) {
559559
$caps[] = 'do_not_allow';
560560
} else {

‎tests/phpunit/tests/user/capabilities.php‎

Lines changed: 56 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -217,77 +217,77 @@ final private function _getMultiSitePrimitiveCaps() {
217217

218218
final private function _getSingleSiteMetaCaps() {
219219
return array(
220-
'create_sites' => array(),
221-
'delete_sites' => array(),
222-
'manage_network' => array(),
223-
'manage_sites' => array(),
224-
'manage_network_users' => array(),
225-
'manage_network_plugins' => array(),
226-
'manage_network_themes' => array(),
227-
'manage_network_options' => array(),
228-
'delete_site' => array(),
229-
'upgrade_network' => array(),
230-
231-
'setup_network' => array( 'administrator' ),
232-
'upload_plugins' => array( 'administrator' ),
233-
'upload_themes' => array( 'administrator' ),
234-
'customize' => array( 'administrator' ),
235-
'add_users' => array( 'administrator' ),
236-
'install_languages' => array( 'administrator' ),
237-
'update_languages' => array( 'administrator' ),
238-
'deactivate_plugins' => array( 'administrator' ),
239-
'upgrade_php' => array( 'administrator' ),
220+
'create_sites' => array(),
221+
'delete_sites' => array(),
222+
'manage_network' => array(),
223+
'manage_sites' => array(),
224+
'manage_network_users' => array(),
225+
'manage_network_plugins' => array(),
226+
'manage_network_themes' => array(),
227+
'manage_network_options' => array(),
228+
'delete_site' => array(),
229+
'upgrade_network' => array(),
230+
231+
'setup_network' => array( 'administrator' ),
232+
'upload_plugins' => array( 'administrator' ),
233+
'upload_themes' => array( 'administrator' ),
234+
'customize' => array( 'administrator' ),
235+
'add_users' => array( 'administrator' ),
236+
'install_languages' => array( 'administrator' ),
237+
'update_languages' => array( 'administrator' ),
238+
'deactivate_plugins' => array( 'administrator' ),
239+
'update_php' => array( 'administrator' ),
240240
'export_others_personal_data' => array( 'administrator' ),
241241
'erase_others_personal_data' => array( 'administrator' ),
242242
'manage_privacy_options' => array( 'administrator' ),
243243

244-
'edit_categories' => array( 'administrator', 'editor' ),
245-
'delete_categories' => array( 'administrator', 'editor' ),
246-
'manage_post_tags' => array( 'administrator', 'editor' ),
247-
'edit_post_tags' => array( 'administrator', 'editor' ),
248-
'delete_post_tags' => array( 'administrator', 'editor' ),
249-
'edit_css' => array( 'administrator', 'editor' ),
244+
'edit_categories' => array( 'administrator', 'editor' ),
245+
'delete_categories' => array( 'administrator', 'editor' ),
246+
'manage_post_tags' => array( 'administrator', 'editor' ),
247+
'edit_post_tags' => array( 'administrator', 'editor' ),
248+
'delete_post_tags' => array( 'administrator', 'editor' ),
249+
'edit_css' => array( 'administrator', 'editor' ),
250250

251-
'assign_categories' => array( 'administrator', 'editor', 'author', 'contributor' ),
252-
'assign_post_tags' => array( 'administrator', 'editor', 'author', 'contributor' ),
251+
'assign_categories' => array( 'administrator', 'editor', 'author', 'contributor' ),
252+
'assign_post_tags' => array( 'administrator', 'editor', 'author', 'contributor' ),
253253
);
254254
}
255255

256256
final private function _getMultiSiteMetaCaps() {
257257
return array(
258-
'create_sites' => array(),
259-
'delete_sites' => array(),
260-
'manage_network' => array(),
261-
'manage_sites' => array(),
262-
'manage_network_users' => array(),
263-
'manage_network_plugins' => array(),
264-
'manage_network_themes' => array(),
265-
'manage_network_options' => array(),
266-
'setup_network' => array(),
267-
'upload_plugins' => array(),
268-
'upload_themes' => array(),
269-
'edit_css' => array(),
270-
'upgrade_network' => array(),
271-
'install_languages' => array(),
272-
'update_languages' => array(),
273-
'deactivate_plugins' => array(),
274-
'upgrade_php' => array(),
258+
'create_sites' => array(),
259+
'delete_sites' => array(),
260+
'manage_network' => array(),
261+
'manage_sites' => array(),
262+
'manage_network_users' => array(),
263+
'manage_network_plugins' => array(),
264+
'manage_network_themes' => array(),
265+
'manage_network_options' => array(),
266+
'setup_network' => array(),
267+
'upload_plugins' => array(),
268+
'upload_themes' => array(),
269+
'edit_css' => array(),
270+
'upgrade_network' => array(),
271+
'install_languages' => array(),
272+
'update_languages' => array(),
273+
'deactivate_plugins' => array(),
274+
'update_php' => array(),
275275
'export_others_personal_data' => array( '' ),
276276
'erase_others_personal_data' => array( '' ),
277-
'manage_privacy_options' => array(),
277+
'manage_privacy_options' => array(),
278278

279-
'customize' => array( 'administrator' ),
280-
'delete_site' => array( 'administrator' ),
281-
'add_users' => array( 'administrator' ),
279+
'customize' => array( 'administrator' ),
280+
'delete_site' => array( 'administrator' ),
281+
'add_users' => array( 'administrator' ),
282282

283-
'edit_categories' => array( 'administrator', 'editor' ),
284-
'delete_categories' => array( 'administrator', 'editor' ),
285-
'manage_post_tags' => array( 'administrator', 'editor' ),
286-
'edit_post_tags' => array( 'administrator', 'editor' ),
287-
'delete_post_tags' => array( 'administrator', 'editor' ),
283+
'edit_categories' => array( 'administrator', 'editor' ),
284+
'delete_categories' => array( 'administrator', 'editor' ),
285+
'manage_post_tags' => array( 'administrator', 'editor' ),
286+
'edit_post_tags' => array( 'administrator', 'editor' ),
287+
'delete_post_tags' => array( 'administrator', 'editor' ),
288288

289-
'assign_categories' => array( 'administrator', 'editor', 'author', 'contributor' ),
290-
'assign_post_tags' => array( 'administrator', 'editor', 'author', 'contributor' ),
289+
'assign_categories' => array( 'administrator', 'editor', 'author', 'contributor' ),
290+
'assign_post_tags' => array( 'administrator', 'editor', 'author', 'contributor' ),
291291
);
292292
}
293293

0 commit comments

Comments
 (0)