make sure nothing going into the object cache is being passed by reference. fixes WordPress#3726

markjaquith · markjaquith · commit af491fc78e5e · 2007-02-01T10:03:34.000Z
git-svn-id: https://develop.svn.wordpress.org/branches/2.1@4857 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/wp-includes/cache.php b/wp-includes/cache.php
@@ -1,6 +1,7 @@
 <?php
 function wp_cache_add($key, $data, $flag = '', $expire = 0) {
 	global $wp_object_cache;
+	$data = unserialize(serialize($data));
 
 	return $wp_object_cache->add($key, $data, $flag, $expire);
 }
@@ -37,12 +38,14 @@ function wp_cache_init() {
 
 function wp_cache_replace($key, $data, $flag = '', $expire = 0) {
 	global $wp_object_cache;
+	$data = unserialize(serialize($data));
 
 	return $wp_object_cache->replace($key, $data, $flag, $expire);
 }
 
 function wp_cache_set($key, $data, $flag = '', $expire = 0) {
 	global $wp_object_cache;
+	$data = unserialize(serialize($data));
 
 	return $wp_object_cache->set($key, $data, $flag, $expire);
 }
diff --git a/wp-includes/version.php b/wp-includes/version.php
@@ -3,6 +3,6 @@
 // This holds the version number in a separate file so we can bump it without cluttering the SVN
 
 $wp_version = '2.1.1-alpha';
-$wp_db_version = 4772;
+$wp_db_version = 4773;
 
 ?>

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`<?php`
`2`	`2`	`function wp_cache_add($key, $data, $flag = '', $expire = 0) {`
`3`	`3`	`global $wp_object_cache;`
	`4`	`+ $data = unserialize(serialize($data));`
`4`	`5`
`5`	`6`	`return $wp_object_cache->add($key, $data, $flag, $expire);`
`6`	`7`	`}`
`@@ -37,12 +38,14 @@ function wp_cache_init() {`
`37`	`38`
`38`	`39`	`function wp_cache_replace($key, $data, $flag = '', $expire = 0) {`
`39`	`40`	`global $wp_object_cache;`
	`41`	`+ $data = unserialize(serialize($data));`
`40`	`42`
`41`	`43`	`return $wp_object_cache->replace($key, $data, $flag, $expire);`
`42`	`44`	`}`
`43`	`45`
`44`	`46`	`function wp_cache_set($key, $data, $flag = '', $expire = 0) {`
`45`	`47`	`global $wp_object_cache;`
	`48`	`+ $data = unserialize(serialize($data));`
`46`	`49`
`47`	`50`	`return $wp_object_cache->set($key, $data, $flag, $expire);`
`48`	`51`	`}`