Hardening: Use a properly generated hash for the newbloguser key instead of a determinate substring.

johnbillion · johnbillion · commit a826ee20a9a9 · 2017-11-29T16:48:28.000Z
Merges [42258] to the 3.7 branch. git-svn-id: https://develop.svn.wordpress.org/branches/3.7@42312 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-admin/user-new.php b/src/wp-admin/user-new.php
@@ -72,7 +72,7 @@ function admin_created_user_subject( $text ) {
 			add_existing_user_to_blog( array( 'user_id' => $user_id, 'role' => $_REQUEST[ 'role' ] ) );
 			$redirect = add_query_arg( array('update' => 'addnoconfirmation'), 'user-new.php' );
 		} else {
-			$newuser_key = substr( md5( $user_id ), 0, 5 );
+			$newuser_key = wp_generate_password( 20, false );
 			add_option( 'new_user_' . $newuser_key, array( 'user_id' => $user_id, 'email' => $user_details->user_email, 'role' => $_REQUEST[ 'role' ] ) );
 
 			$roles = get_editable_roles();
