Build/Test Tools: Pass correct $message argument to WP_UnitTestCase::setExpectedException() in Tests_Ajax_CompressionTest::test_logged_out() and Tests_Ajax_TagSearch::test_no_results().

SergeyBiryukov · SergeyBiryukov · commit a722bac3edc9 · 2017-10-16T04:05:29.000Z
PHPUnit 6.4.1 and earlier versions ignored the `'0'` value, causing the issue to go unnoticed. Fixes #42232. git-svn-id: https://develop.svn.wordpress.org/trunk@41870 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/tests/phpunit/tests/ajax/Compression.php b/tests/phpunit/tests/ajax/Compression.php
@@ -25,7 +25,7 @@ public function test_logged_out() {
 		$_GET['test'] = 1;
 
 		// Make the request
-		$this->setExpectedException( 'WPAjaxDieStopException', '0' );
+		$this->setExpectedException( 'WPAjaxDieStopException', '-1' );
 		$this->_handleAjax( 'wp-compression-test' );
 	}
 
diff --git a/tests/phpunit/tests/ajax/TagSearch.php b/tests/phpunit/tests/ajax/TagSearch.php
@@ -68,7 +68,7 @@ public function test_no_results() {
 
 		// Make the request
 		// No output, so we get a stop exception
-		$this->setExpectedException( 'WPAjaxDieStopException', '0' );
+		$this->setExpectedException( 'WPAjaxDieStopException', '' );
 		$this->_handleAjax( 'ajax-tag-search' );
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ public function test_logged_out() {`
`25`	`25`	`$_GET['test'] = 1;`
`26`	`26`
`27`	`27`	`// Make the request`
`28`		`- $this->setExpectedException( 'WPAjaxDieStopException', '0' );`
	`28`	`+ $this->setExpectedException( 'WPAjaxDieStopException', '-1' );`
`29`	`29`	`$this->_handleAjax( 'wp-compression-test' );`
`30`	`30`	`}`
`31`	`31`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ public function test_no_results() {`
`68`	`68`
`69`	`69`	`// Make the request`
`70`	`70`	`// No output, so we get a stop exception`
`71`		`- $this->setExpectedException( 'WPAjaxDieStopException', '0' );`
	`71`	`+ $this->setExpectedException( 'WPAjaxDieStopException', '' );`
`72`	`72`	`$this->_handleAjax( 'ajax-tag-search' );`
`73`	`73`	`}`
`74`	`74`