Consistently call skin methods in WP_Upgrader. fixes #25254.

SergeyBiryukov · SergeyBiryukov · commit a56e83373dcb · 2013-09-12T02:42:10.000Z
git-svn-id: https://develop.svn.wordpress.org/trunk@25370 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-admin/includes/class-wp-upgrader.php b/src/wp-admin/includes/class-wp-upgrader.php
@@ -299,21 +299,26 @@ function run($options) {
 		if ( ! $res ) //Mainly for non-connected filesystem.
 			return false;
 
+		if ( ! $is_multi ) // call $this->header separately if running multiple times
+			$this->skin->header();
+
+		$this->skin->before();
+
 		if ( is_wp_error($res) ) {
 			$this->skin->error($res);
+			$this->skin->after();
+			if ( ! $is_multi )
+				$this->skin->footer();
 			return $res;
 		}
 
-		if ( !$is_multi ) // call $this->header separately if running multiple times
-			$this->skin->header();
-
-		$this->skin->before();
-
 		//Download the package (Note, This just returns the filename of the file if the package is a local file)
 		$download = $this->download_package( $package );
 		if ( is_wp_error($download) ) {
 			$this->skin->error($download);
 			$this->skin->after();
+			if ( ! $is_multi )
+				$this->skin->footer();
 			return $download;
 		}
 
@@ -324,6 +329,8 @@ function run($options) {
 		if ( is_wp_error($working_dir) ) {
 			$this->skin->error($working_dir);
 			$this->skin->after();
+			if ( ! $is_multi )
+				$this->skin->footer();
 			return $working_dir;
 		}
 
@@ -345,9 +352,10 @@ function run($options) {
 			//Install Succeeded
 			$this->skin->feedback('process_success');
 		}
+
 		$this->skin->after();
 
-		if ( !$is_multi )
+		if ( ! $is_multi )
 			$this->skin->footer();
 
 		return $result;
