Themes: Avoid undefined variable warning on get_svg_filters().

audrasjb · audrasjb · commit 930b56bd367a · 2022-03-29T09:10:55.000Z
This change fixes an undefined variable warning thrown when `duotone` color setting was set to null in Block Themes `theme.json` file. Follow-up to [52768]. Props aliakseyenkaihar, audrasjb, rafiahmedd. Merges [52791] to the 5.9 branch. Fixes #55241. git-svn-id: https://develop.svn.wordpress.org/branches/5.9@53009 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/class-wp-theme-json.php b/src/wp-includes/class-wp-theme-json.php
@@ -1598,6 +1598,7 @@ public function get_svg_filters( $origins ) {
 		$blocks_metadata = static::get_blocks_metadata();
 		$setting_nodes   = static::get_setting_nodes( $this->theme_json, $blocks_metadata );
 
+		$filters = '';
 		foreach ( $setting_nodes as $metadata ) {
 			$node = _wp_array_get( $this->theme_json, $metadata['path'], array() );
 			if ( empty( $node['color']['duotone'] ) ) {
@@ -1606,7 +1607,6 @@ public function get_svg_filters( $origins ) {
 
 			$duotone_presets = $node['color']['duotone'];
 
-			$filters = '';
 			foreach ( $origins as $origin ) {
 				if ( ! isset( $duotone_presets[ $origin ] ) ) {
 					continue;
