Smilies optimization from Nazgul. fixes WordPress#3201 WordPress#3216

ryanboren · ryanboren · commit 28a0e3786cbf · 2006-10-07T19:16:24.000Z
git-svn-id: https://develop.svn.wordpress.org/trunk@4360 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/wp-includes/formatting.php b/wp-includes/formatting.php
@@ -618,14 +618,7 @@ function convert_smilies($text) {
 	if (get_option('use_smilies')) {
 		// HTML loop taken from texturize function, could possible be consolidated
 		$textarr = preg_split("/(<.*>)/U", $text, -1, PREG_SPLIT_DELIM_CAPTURE); // capture the tags as well as in between
-		$stop = count($textarr);// loop stuff
-		for ($i = 0; $i < $stop; $i++) {
-			$content = $textarr[$i];
-			if ((strlen($content) > 0) && ('<' != $content{0})) { // If it's not a tag
-				$content = preg_replace($wp_smiliessearch, $wp_smiliesreplace, $content);
-			}
-			$output .= $content;
-		}
+		$output = implode('', preg_replace($wp_smiliessearch, $wp_smiliesreplace, $textarr));
 	} else {
 		// return default text.
 		$output = $text;
diff --git a/wp-includes/vars.php b/wp-includes/vars.php
@@ -87,7 +87,7 @@
 
 // generates smilies' search & replace arrays
 foreach($wpsmiliestrans as $smiley => $img) {
-	$wp_smiliessearch[] = '/(\s|^)?'.preg_quote($smiley, '/').'(\b|\s)/';
+	$wp_smiliessearch[] = '/(\s|^|[^<])?'.preg_quote($smiley, '/').'(\b|\s|$)/';
 	$smiley_masked = htmlspecialchars( trim($smiley) , ENT_QUOTES);
 	$wp_smiliesreplace[] = " <img src='" . get_option('siteurl') . "/wp-includes/images/smilies/$img' alt='$smiley_masked' class='wp-smiley' /> ";
 }

Original file line number	Diff line number	Diff line change
`@@ -87,7 +87,7 @@`
`87`	`87`
`88`	`88`	`// generates smilies' search & replace arrays`
`89`	`89`	`foreach($wpsmiliestrans as $smiley => $img) {`
`90`		`- $wp_smiliessearch[] = '/(\s\|^)?'.preg_quote($smiley, '/').'(\b\|\s)/';`
	`90`	`+ $wp_smiliessearch[] = '/(\s\|^\|[^<])?'.preg_quote($smiley, '/').'(\b\|\s\|$)/';`
`91`	`91`	`$smiley_masked = htmlspecialchars( trim($smiley) , ENT_QUOTES);`
`92`	`92`	`$wp_smiliesreplace[] = " <img src='" . get_option('siteurl') . "/wp-includes/images/smilies/$img' alt='$smiley_masked' class='wp-smiley' /> ";`
`93`	`93`	`}`