Prevent errors in assigning widgets to sidebars for themes with dynamic sidebars, props batmoo, fixes #19274

azaozz · azaozz · commit 0f3de5ede99c · 2011-11-18T07:00:26.000Z
git-svn-id: https://develop.svn.wordpress.org/trunk@19334 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/wp-admin/widgets.php b/wp-admin/widgets.php
@@ -62,18 +62,21 @@ function wp_widgets_access_body_class($classes) {
 	if ( 'wp_inactive_widgets' == $sidebar_id )
 		continue;
 
-	if ( empty( $wp_registered_sidebars[ $sidebar_id ] ) && ! empty( $widgets ) ) {
-		// register the inactive_widgets area as sidebar
-		register_sidebar(array(
-			'name' => __( 'Inactive Sidebar (from previous theme)' ),
-			'id' => $sidebar_id,
-			'class' => 'inactive-sidebar orphan-sidebar',
-			'description' => __( 'This is a left over sidebar from an old theme and does not show anywhere on your site' ),
-			'before_widget' => '',
-			'after_widget' => '',
-			'before_title' => '',
-			'after_title' => '',
-		));
+	if ( !isset( $wp_registered_sidebars[ $sidebar_id ] ) ) {
+		if ( ! empty( $widgets ) ) { // register the inactive_widgets area as sidebar
+			register_sidebar(array(
+				'name' => __( 'Inactive Sidebar (from previous theme)' ),
+				'id' => $sidebar_id,
+				'class' => 'inactive-sidebar orphan-sidebar',
+				'description' => __( 'This is a left over sidebar from an old theme and does not show anywhere on your site' ),
+				'before_widget' => '',
+				'after_widget' => '',
+				'before_title' => '',
+				'after_title' => '',
+			));
+		} else {
+			unset( $sidebars_widgets[ $sidebar_id ] );
+		}
 	}
 }
 
