Allow query strings for servers in IXR_Client and WP_HTTP_IXR_Client.

nacin · nacin · commit 0ed014743d9a · 2014-03-15T05:00:27.000Z
props cfinke. fixes #26947. git-svn-id: https://develop.svn.wordpress.org/trunk@27552 602fd350-edb4-49c9-b593-d223f7449a82
diff --git a/src/wp-includes/class-IXR.php b/src/wp-includes/class-IXR.php
@@ -629,6 +629,10 @@ function IXR_Client($server, $path = false, $port = 80, $timeout = 15)
             if (!$this->path) {
                 $this->path = '/';
             }
+
+            if ( ! empty( $bits['query'] ) ) {
+                $this->path .= '?' . $bits['query'];
+            }
         } else {
             $this->server = $server;
             $this->path = $path;
diff --git a/src/wp-includes/class-wp-http-ixr-client.php b/src/wp-includes/class-wp-http-ixr-client.php
@@ -18,8 +18,13 @@ function __construct($server, $path = false, $port = false, $timeout = 15) {
 			$this->path = !empty($bits['path']) ? $bits['path'] : '/';
 
 			// Make absolutely sure we have a path
-			if ( ! $this->path )
+			if ( ! $this->path ) {
 				$this->path = '/';
+			}
+				
+			if ( ! empty( $bits['query'] ) ) {
+				$this->path .= '?' . $bits['query'];
+			}
 		} else {
 			$this->scheme = 'http';
 			$this->server = $server;
diff --git a/tests/phpunit/tests/xmlrpc/client.php b/tests/phpunit/tests/xmlrpc/client.php
@@ -0,0 +1,30 @@
+<?php
+require_once ABSPATH . WPINC . '/class-IXR.php';
+require_once ABSPATH . WPINC . '/class-wp-http-ixr-client.php';
+
+/**
+ * @group xmlrpc
+ */
+class Tests_XMLRPC_Client extends WP_XMLRPC_UnitTestCase {
+
+	/**
+	 * @ticket 26947
+	 */
+	function test_ixr_client_allows_query_strings() {
+		$client = new IXR_Client( 'http://example.com/server.php?this-is-needed=true#not-this' );
+		$this->assertEquals( 'example.com', $client->server );
+		$this->assertEquals( 80, $client->port );
+		$this->assertEquals( '/server.php?this-is-needed=true', $client->path );
+	}
+
+	/**
+	 * @ticket 26947
+	 */
+	function test_wp_ixr_client_allows_query_strings() {
+		$client = new WP_HTTP_IXR_Client( 'http://example.com/server.php?this-is-needed=true#not-this' );
+		$this->assertEquals( 'example.com', $client->server );
+		$this->assertFalse( $client->port );
+		$this->assertEquals( '/server.php?this-is-needed=true', $client->path );
+	}
+}
+
