Fixed dashed line issue on x-axis grid (issue PhilJay#755).

PhilJay · PhilJay · commit 978201c072f2 · 2015-06-12T18:13:16.000+02:00
diff --git a/MPChartLib/src/com/github/mikephil/charting/renderer/XAxisRenderer.java b/MPChartLib/src/com/github/mikephil/charting/renderer/XAxisRenderer.java
@@ -163,6 +163,7 @@ public void renderGridLines(Canvas c) {
         if (!mXAxis.isDrawGridLinesEnabled() || !mXAxis.isEnabled())
             return;
 
+        // pre alloc
         float[] position = new float[] {
                 0f, 0f
         };
@@ -171,18 +172,24 @@ public void renderGridLines(Canvas c) {
         mGridPaint.setStrokeWidth(mXAxis.getGridLineWidth());
         mGridPaint.setPathEffect(mXAxis.getGridDashPathEffect());
 
+        Path gridLinePath = new Path();
+
         for (int i = mMinX; i <= mMaxX; i += mXAxis.mAxisLabelModulus) {
 
             position[0] = i;
-
             mTrans.pointValuesToPixel(position);
 
             if (position[0] >= mViewPortHandler.offsetLeft()
                     && position[0] <= mViewPortHandler.getChartWidth()) {
 
-                c.drawLine(position[0], mViewPortHandler.offsetTop(), position[0],
-                        mViewPortHandler.contentBottom(), mGridPaint);
+                gridLinePath.moveTo(position[0], mViewPortHandler.contentBottom());
+                gridLinePath.lineTo(position[0], mViewPortHandler.contentTop());
+
+                // draw a path because lines don't support dashing on lower android versions
+                c.drawPath(gridLinePath, mGridPaint);
             }
+
+            gridLinePath.reset();
         }
     }
 
diff --git a/MPChartLib/src/com/github/mikephil/charting/renderer/YAxisRenderer.java b/MPChartLib/src/com/github/mikephil/charting/renderer/YAxisRenderer.java
@@ -253,6 +253,7 @@ public void renderGridLines(Canvas c) {
             gridLinePath.lineTo(mViewPortHandler.contentRight(),
                     position[1]);
 
+            // draw a path because lines don't support dashing on lower android versions
             c.drawPath(gridLinePath, mGridPaint);
 
             gridLinePath.reset();
