Skip to content

Commit c6c6628

Browse files
committed
Fix hasMany custom keys join table (dresende#510)
1 parent 1cd44d8 commit c6c6628

File tree

3 files changed

+516
-368
lines changed

3 files changed

+516
-368
lines changed

Changelog.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
### v2.1.?? - ???
2+
- Fix hasMany join tables with custom id columns (#510)
3+
14
### v2.1.14 - 22 May 2014
25
- Allow explicitly specifying `key: true` on properties rather than passing in an array of ids.
36
- Fix Property.mapsTo (#506)

lib/Associations/Many.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,14 @@ exports.prepare = function (db, Model, associations) {
4444
makeKey = opts.key || Settings.defaults().hasMany.key;
4545

4646
mergeId = util.convertPropToJoinKeyProp(
47-
util.wrapFieldObject(opts.mergeId, OtherModel, Model.table, OtherModel.properties) ||
48-
util.formatField(OtherModel, Model.table, true, opts.reversed),
47+
util.wrapFieldObject(opts.mergeId, Model, Model.table, Model.properties) ||
48+
util.formatField(Model, Model.table, true, opts.reversed),
4949
{ makeKey: makeKey, required: true }
5050
);
5151

5252
mergeAssocId = util.convertPropToJoinKeyProp(
53-
util.wrapFieldObject(opts.mergeAssocId, Model, name, Model.properties) ||
54-
util.formatField(Model, name, true, opts.reversed),
53+
util.wrapFieldObject(opts.mergeAssocId, OtherModel, name, OtherModel.properties) ||
54+
util.formatField(OtherModel, name, true, opts.reversed),
5555
{ makeKey: makeKey, required: true }
5656
)
5757

0 commit comments

Comments
 (0)