style: include SUI_CONTAINS_BEFORE_ADD (TheAlgorithms#5216)

vil02 · web-flow · commit 31db1af345b0 · 2024-06-13T17:27:49.000Z
diff --git a/spotbugs-exclude.xml b/spotbugs-exclude.xml
@@ -222,9 +222,6 @@
     <Match>
         <Bug pattern="IMC_IMMATURE_CLASS_BAD_SERIALVERSIONUID" />
     </Match>
-    <Match>
-        <Bug pattern="SUI_CONTAINS_BEFORE_ADD" />
-    </Match>
     <Match>
         <Bug pattern="DRE_DECLARED_RUNTIME_EXCEPTION" />
     </Match>
diff --git a/src/main/java/com/thealgorithms/datastructures/graphs/ConnectedComponent.java b/src/main/java/com/thealgorithms/datastructures/graphs/ConnectedComponent.java
@@ -81,8 +81,7 @@ public int countGraphs() {
         Set<Node> markedNodes = new HashSet<Node>();
 
         for (Node n : nodeList) {
-            if (!markedNodes.contains(n)) {
-                markedNodes.add(n);
+            if (markedNodes.add(n)) {
                 markedNodes.addAll(depthFirstSearch(n, new ArrayList<Node>()));
                 count++;
             }

Original file line number	Diff line number	Diff line change
`@@ -81,8 +81,7 @@ public int countGraphs() {`
`81`	`81`	`Set<Node> markedNodes = new HashSet<Node>();`
`82`	`82`
`83`	`83`	`for (Node n : nodeList) {`
`84`		`- if (!markedNodes.contains(n)) {`
`85`		`- markedNodes.add(n);`
	`84`	`+ if (markedNodes.add(n)) {`
`86`	`85`	`markedNodes.addAll(depthFirstSearch(n, new ArrayList<Node>()));`
`87`	`86`	`count++;`
`88`	`87`	`}`