Skip to content

Commit 9dc42d8

Browse files
committed
Fixed not being able to get the entity handle from a non-networked entity
This also improves the performance all BaseHandleFrom* and IntHandleFrom* functions
1 parent e73b9a3 commit 9dc42d8

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/core/utilities/conversions.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -515,8 +515,7 @@ inline CBaseHandle BaseHandleFromIntHandle( int iEntityHandle, bool bRaiseExcept
515515
//-----------------------------------------------------------------------------
516516
inline CBaseHandle BaseHandleFromBaseEntity( CBaseEntity *pBaseEntity, bool bRaiseException = false)
517517
{
518-
CBaseHandle hBaseHandle = BaseHandleFromEdict(EdictFromBaseEntity(pBaseEntity));
519-
518+
CBaseHandle hBaseHandle = pBaseEntity->GetRefEHandle();
520519
if (!hBaseHandle.ToInt() && bRaiseException)
521520
BOOST_RAISE_EXCEPTION(PyExc_ValueError, "Unable to get a BaseHandle instance from the given BaseEntity instance (%x).", pBaseEntity);
522521

@@ -599,7 +598,7 @@ inline int IntHandleFromEdict( edict_t *pEdict, bool bRaiseException = false )
599598
//-----------------------------------------------------------------------------
600599
inline int IntHandleFromBaseEntity( CBaseEntity *pBaseEntity, bool bRaiseException = false )
601600
{
602-
int iEntityHandle = IntHandleFromEdict(EdictFromBaseEntity(pBaseEntity));
601+
int iEntityHandle = IntHandleFromBaseHandle(BaseHandleFromBaseEntity(pBaseEntity));
603602

604603
if (iEntityHandle == (int) INVALID_EHANDLE_INDEX && bRaiseException)
605604
BOOST_RAISE_EXCEPTION(PyExc_ValueError, "Unable to get an IntHandle from the given BaseEntity instance (%x).", pBaseEntity);

0 commit comments

Comments
 (0)