Ugly hack for messagebus to return results [hack_messagebus_results]

hjwp · hjwp · commit c6d5aae3d5bd · 2020-02-21T12:05:48.000Z
diff --git a/src/allocation/service_layer/messagebus.py b/src/allocation/service_layer/messagebus.py
@@ -7,12 +7,14 @@
 
 
 def handle(event: events.Event, uow: unit_of_work.AbstractUnitOfWork):
+    results = []
     queue = [event]
     while queue:
         event = queue.pop(0)
         for handler in HANDLERS[type(event)]:
-            handler(event, uow=uow)
+            results.append(handler(event, uow=uow))
             queue.extend(uow.collect_new_events())
+    return results
 
 
 HANDLERS = {
diff --git a/tests/unit/test_handlers.py b/tests/unit/test_handlers.py
@@ -60,10 +60,10 @@ def test_returns_allocation(self):
         messagebus.handle(
             events.BatchCreated("batch1", "COMPLICATED-LAMP", 100, None), uow
         )
-        result = messagebus.handle(
+        results = messagebus.handle(
             events.AllocationRequired("o1", "COMPLICATED-LAMP", 10), uow
         )
-        assert result == "batch1"
+        assert results.pop(0) == "batch1"
 
 
     def test_errors_for_invalid_sku(self):

Original file line number	Diff line number	Diff line change
`@@ -60,10 +60,10 @@ def test_returns_allocation(self):`
`60`	`60`	`messagebus.handle(`
`61`	`61`	`events.BatchCreated("batch1", "COMPLICATED-LAMP", 100, None), uow`
`62`	`62`	`)`
`63`		`- result = messagebus.handle(`
	`63`	`+ results = messagebus.handle(`
`64`	`64`	`events.AllocationRequired("o1", "COMPLICATED-LAMP", 10), uow`
`65`	`65`	`)`
`66`		`- assert result == "batch1"`
	`66`	`+ assert results.pop(0) == "batch1"`
`67`	`67`
`68`	`68`
`69`	`69`	`def test_errors_for_invalid_sku(self):`