tests for notifcations [notifications_unit_tests]

hjwp · hjwp · commit b3aa84413822 · 2020-03-05T19:59:44.000Z
diff --git a/tests/integration/test_views.py b/tests/integration/test_views.py
@@ -1,6 +1,7 @@
 # pylint: disable=redefined-outer-name
 from datetime import date
 from sqlalchemy.orm import clear_mappers
+from unittest import mock
 import pytest
 from allocation import bootstrap, views
 from allocation.domain import commands
@@ -14,7 +15,7 @@ def sqlite_bus(sqlite_session_factory):
     bus = bootstrap.bootstrap(
         start_orm=True,
         uow=unit_of_work.SqlAlchemyUnitOfWork(sqlite_session_factory),
-        send_mail=lambda *args: None,
+        notifications=mock.Mock(),
         publish=lambda *args: None,
     )
     yield bus
diff --git a/tests/unit/test_handlers.py b/tests/unit/test_handlers.py
@@ -1,12 +1,14 @@
 # pylint: disable=no-self-use
 from __future__ import annotations
+from collections import defaultdict
 from datetime import date
-from unittest import mock
+from typing import Dict, List
 import pytest
 from allocation import bootstrap
-from allocation.adapters import repository
 from allocation.domain import commands
-from allocation.service_layer import handlers, unit_of_work
+from allocation.service_layer import handlers
+from allocation.adapters import notifications, repository
+from allocation.service_layer import unit_of_work
 
 
 class FakeRepository(repository.AbstractRepository):
@@ -41,11 +43,21 @@ def rollback(self):
         pass
 
 
+class FakeNotifications(notifications.AbstractNotifications):
+
+    def __init__(self):
+        self.sent = defaultdict(list)  # type: Dict[str, List[str]]
+
+    def send(self, destination, message):
+        self.sent[destination].append(message)
+
+
+
 def bootstrap_test_app():
     return bootstrap.bootstrap(
         start_orm=False,
         uow=FakeUnitOfWork(),
-        send_mail=lambda *args: None,
+        notifications=FakeNotifications(),
         publish=lambda *args: None,
     )
 
@@ -92,19 +104,17 @@ def test_commits(self):
 
 
     def test_sends_email_on_out_of_stock_error(self):
-        emails = []
-        def fake_send_mail(*args):
-            emails.append(args)
+        fake_notifs = FakeNotifications()
         bus = bootstrap.bootstrap(
             start_orm=False,
             uow=FakeUnitOfWork(),
-            send_mail=fake_send_mail,
+            notifications=fake_notifs,
             publish=lambda *args: None,
         )
         bus.handle(commands.CreateBatch("b1", "POPULAR-CURTAINS", 9, None))
         bus.handle(commands.Allocate("o1", "POPULAR-CURTAINS", 10))
-        assert emails == [
-            ("stock@made.com", f"Out of stock for POPULAR-CURTAINS"),
+        assert fake_notifs.sent['stock@made.com'] == [
+            f"Out of stock for POPULAR-CURTAINS",
         ]
 
 
