Reference::Finalize/RefBase::Finalize was generalized

Xmader · Xmader · commit 823bbf728595 · 2025-11-24T13:29:46.000Z
See nodejs#44141
diff --git a/src/js_native_api_v8.cc b/src/js_native_api_v8.cc
@@ -339,7 +339,8 @@ class ArrayBufferReference final : public Reference {
   explicit ArrayBufferReference(napi_env env,
                                 v8::Local<v8::ArrayBuffer> value,
                                 Args&&... args)
-    : Reference(env, value, std::forward<Args>(args)...) {}
+    : Reference(env, value, std::forward<Args>(args)...),
+      _env(env) {}
 
   template <typename... Args>
   static ArrayBufferReference* New(napi_env env,
@@ -349,18 +350,18 @@ class ArrayBufferReference final : public Reference {
   }
 
  private:
-  inline void Finalize(bool is_env_teardown) override {
-    if (is_env_teardown) {
-      v8::HandleScope handle_scope(_env->isolate);
-      v8::Local<v8::Value> obj = Get();
-      CHECK(!obj.IsEmpty());
-      CHECK(obj->IsArrayBuffer());
-      v8::Local<v8::ArrayBuffer> ab = obj.As<v8::ArrayBuffer>();
-      if (ab->IsDetachable())
-        ab->Detach();
-    }
-
-    Reference::Finalize(is_env_teardown);
+  napi_env _env;
+
+  inline void Finalize() override {
+    v8::HandleScope handle_scope(_env->isolate);
+    v8::Local<v8::Value> obj = Get();
+    CHECK(!obj.IsEmpty());
+    CHECK(obj->IsArrayBuffer());
+    v8::Local<v8::ArrayBuffer> ab = obj.As<v8::ArrayBuffer>();
+    if (ab->IsDetachable())
+      ab->Detach();
+
+    Reference::Finalize();
   }
 };
 #endif
