Skip to content

Commit 607e377

Browse files
pull[bot]cpsievert
pull[bot]
and
cpsievert
authored
[pull] master from ropensci:master (#6)
* Get ggplotly() playing nicely with thematic (plotly#1801) * Pull plotly's custom ggplot_build into a function and hook into thematic if relevant * add thematic to suggests and use it only when loaded * update shinytest tests * Go back to the assign() based approach * bust cache * CRAN version of crosstalk * add visual tests * update news Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
1 parent 2349a7d commit 607e377

18 files changed

Lines changed: 254 additions & 202 deletions

File tree

‎DESCRIPTION‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,10 @@ Suggests:
7272
IRdisplay,
7373
processx,
7474
plotlyGeoAssets,
75-
forcats
75+
forcats,
76+
thematic
7677
LazyData: true
7778
RoxygenNote: 7.1.0
7879
Encoding: UTF-8
7980
Roxygen: list(markdown = TRUE)
81+
Remotes: rstudio/thematic

‎NEWS.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,10 @@ This is minor patch release with a few minor bug fixes and updates test expectat
4242

4343
* This version of the R package upgrades the version of the underlying plotly.js library from v1.52.2 to v1.54.1. This includes many bug fixes and improvements. The [plotly.js release page](https://github.com/plotly/plotly.js/releases) has the full list of changes.
4444

45+
## NEW FEATURES
46+
47+
* `ggplotly()` now works well with the [**thematic** package](https://rstudio.github.io/thematic). That is, it can now correctly translate **ggplot2** styling that derives from **thematic** (#1801).
48+
4549
## IMPROVEMENTS
4650

4751
* All HTTP requests are now retried upon failure (#1656, @jameslamb).

0 commit comments

Comments
 (0)