Revert unnecesary lcase in ds-identify (canonical#978)

akutz · web-flow · commit f516a7d37c16 · 2021-08-13T14:30:55.000-05:00
This patch reverts an unnecessary lcase optimization in the
ds-identify script. SystemD documents the values produced by
the systemd-detect-virt command are lower case, and the mapping
table used by the FreeBSD check is also lower-case.

The optimization added two new forked processes, needlessly
causing overhead.
diff --git a/tools/ds-identify b/tools/ds-identify
@@ -449,7 +449,7 @@ detect_virt() {
 read_virt() {
     cached "$DI_VIRT" && return 0
     detect_virt
-    DI_VIRT="$(echo "${_RET}" | tr '[:upper:]' '[:lower:]')"
+    DI_VIRT="${_RET}"
 }
 
 is_container() {

Original file line number	Diff line number	Diff line change
`@@ -449,7 +449,7 @@ detect_virt() {`
`449`	`449`	`read_virt() {`
`450`	`450`	`cached "$DI_VIRT" && return 0`
`451`	`451`	`detect_virt`
`452`		`- DI_VIRT="$(echo "${_RET}" \| tr '[:upper:]' '[:lower:]')"`
	`452`	`+ DI_VIRT="${_RET}"`
`453`	`453`	`}`
`454`	`454`
`455`	`455`	`is_container() {`