query: do not handle non-decodable non-gzipped content (canonical#543)

blackboxsw · web-flow · commit c0450c02b25f · 2020-08-24T10:13:52.000-06:00
diff --git a/cloudinit/cmd/query.py b/cloudinit/cmd/query.py
@@ -86,14 +86,11 @@ def load_userdata(ud_file_path):
 
     @returns: String of uncompressed userdata if possible, otherwise bytes.
     """
+    bdata = util.load_file(ud_file_path, decode=False)
     try:
-        return util.load_file(ud_file_path)
+        return bdata.decode('utf-8')
     except UnicodeDecodeError:
-        encoded_data = util.load_file(ud_file_path, decode=False)
-        try:
-            return util.decomp_gzip(encoded_data, quiet=False)
-        except util.DecompressionError:
-            return encoded_data
+        return util.decomp_gzip(bdata, quiet=False, decode=True)
 
 
 def handle_args(name, args):
diff --git a/cloudinit/cmd/tests/test_query.py b/cloudinit/cmd/tests/test_query.py
@@ -144,11 +144,6 @@ def test_handle_args_root_fallsback_to_instance_data(self, caplog, tmpdir):
             ('ud'.encode('utf-8'), 'ud', 'vd'.encode('utf-8'), 'vd'),
             (_gzip_data(b'ud'), 'ud', _gzip_data(b'vd'), 'vd'),
             (_gzip_data('ud'.encode('utf-8')), 'ud', _gzip_data(b'vd'), 'vd'),
-            (_gzip_data(b'ud') + b'invalid', 'ci-b64:',
-             _gzip_data(b'vd') + b'invalid', 'ci-b64:'),
-            # non-utf-8 encodable content
-            ('hi mom'.encode('utf-16'), 'ci-b64://5oAGkAIABtAG8AbQA=',
-             'hi pops'.encode('utf-16'), 'ci-b64://5oAGkAIABwAG8AcABzAA=='),
         )
     )
     def test_handle_args_root_processes_user_data(

Original file line number	Diff line number	Diff line change
`@@ -144,11 +144,6 @@ def test_handle_args_root_fallsback_to_instance_data(self, caplog, tmpdir):`
`144`	`144`	`('ud'.encode('utf-8'), 'ud', 'vd'.encode('utf-8'), 'vd'),`
`145`	`145`	`(_gzip_data(b'ud'), 'ud', _gzip_data(b'vd'), 'vd'),`
`146`	`146`	`(_gzip_data('ud'.encode('utf-8')), 'ud', _gzip_data(b'vd'), 'vd'),`
`147`		`- (_gzip_data(b'ud') + b'invalid', 'ci-b64:',`
`148`		`- _gzip_data(b'vd') + b'invalid', 'ci-b64:'),`
`149`		`- # non-utf-8 encodable content`
`150`		`- ('hi mom'.encode('utf-16'), 'ci-b64://5oAGkAIABtAG8AbQA=',`
`151`		`- 'hi pops'.encode('utf-16'), 'ci-b64://5oAGkAIABwAG8AcABzAA=='),`
`152`	`147`	`)`
`153`	`148`	`)`
`154`	`149`	`def test_handle_args_root_processes_user_data(`