Skip to content

Commit 3522b7b

Browse files
committed
rename DataSourceMaaS to DataSourceMAAS, generally use MAAS everywhere
instead of MaaS or Maas, use MAAS consistently. The only non 'MAAS' left are all lower case.
1 parent aa9b2a8 commit 3522b7b

File tree

5 files changed

+32
-32
lines changed

5 files changed

+32
-32
lines changed
Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@
3131
MD_VERSION = "2012-03-01"
3232

3333

34-
class DataSourceMaaS(DataSource.DataSource):
34+
class DataSourceMAAS(DataSource.DataSource):
3535
"""
36-
DataSourceMaaS reads instance information from MaaS.
36+
DataSourceMAAS reads instance information from MAAS.
3737
Given a config metadata_url, and oauth tokens, it expects to find
3838
files under the root named:
3939
instance-id
@@ -44,7 +44,7 @@ class DataSourceMaaS(DataSource.DataSource):
4444
baseurl = None
4545

4646
def __str__(self):
47-
return("DataSourceMaaS[%s]" % self.baseurl)
47+
return("DataSourceMAAS[%s]" % self.baseurl)
4848

4949
def get_data(self):
5050
mcfg = self.ds_cfg
@@ -55,9 +55,9 @@ def get_data(self):
5555
self.metadata = metadata
5656
self.baseurl = self.seeddir
5757
return True
58-
except MaasSeedDirNone:
58+
except MAASSeedDirNone:
5959
pass
60-
except MaasSeedDirMalformed as exc:
60+
except MAASSeedDirMalformed as exc:
6161
log.warn("%s was malformed: %s\n" % (self.seeddir, exc))
6262
raise
6363

@@ -143,7 +143,7 @@ def read_maas_seed_dir(seed_d):
143143
md = {}
144144

145145
if not os.path.isdir(seed_d):
146-
raise MaasSeedDirNone("%s: not a directory")
146+
raise MAASSeedDirNone("%s: not a directory")
147147

148148
for fname in files:
149149
try:
@@ -195,17 +195,17 @@ def check_seed_contents(content, seed):
195195
"""Validate if content is Is the content a dict that is valid as a
196196
return for a datasource.
197197
Either return a (userdata, metadata) tuple or
198-
Raise MaasSeedDirMalformed or MaasSeedDirNone
198+
Raise MAASSeedDirMalformed or MAASSeedDirNone
199199
"""
200200
md_required = ('instance-id', 'local-hostname')
201201
found = content.keys()
202202

203203
if len(content) == 0:
204-
raise MaasSeedDirNone("%s: no data files found" % seed)
204+
raise MAASSeedDirNone("%s: no data files found" % seed)
205205

206206
missing = [k for k in md_required if k not in found]
207207
if len(missing):
208-
raise MaasSeedDirMalformed("%s: missing files %s" % (seed, missing))
208+
raise MAASSeedDirMalformed("%s: missing files %s" % (seed, missing))
209209

210210
userdata = content.get('user-data', "")
211211
md = {}
@@ -233,16 +233,16 @@ def oauth_headers(url, consumer_key, token_key, token_secret, consumer_secret):
233233
return(req.to_header())
234234

235235

236-
class MaasSeedDirNone(Exception):
236+
class MAASSeedDirNone(Exception):
237237
pass
238238

239239

240-
class MaasSeedDirMalformed(Exception):
240+
class MAASSeedDirMalformed(Exception):
241241
pass
242242

243243

244244
datasources = [
245-
(DataSourceMaaS, (DataSource.DEP_FILESYSTEM, DataSource.DEP_NETWORK)),
245+
(DataSourceMAAS, (DataSource.DEP_FILESYSTEM, DataSource.DEP_NETWORK)),
246246
]
247247

248248

@@ -261,7 +261,7 @@ def main():
261261
import argparse
262262
import pprint
263263

264-
parser = argparse.ArgumentParser(description='Interact with Maas DS')
264+
parser = argparse.ArgumentParser(description='Interact with MAAS DS')
265265
parser.add_argument("--config", metavar="file",
266266
help="specify DS config file", default=None)
267267
parser.add_argument("--ckey", metavar="key",
@@ -292,7 +292,7 @@ def main():
292292
with open(args.config) as fp:
293293
cfg = yaml.load(fp)
294294
if 'datasource' in cfg:
295-
cfg = cfg['datasource']['MaaS']
295+
cfg = cfg['datasource']['MAAS']
296296
for key in creds.keys():
297297
if key in cfg and creds[key] == None:
298298
creds[key] = cfg[key]

cloudinit/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929

3030
cfg_builtin = """
3131
log_cfgs: []
32-
datasource_list: ["NoCloud", "ConfigDrive", "OVF", "MaaS", "Ec2", "CloudStack"]
32+
datasource_list: ["NoCloud", "ConfigDrive", "OVF", "MAAS", "Ec2", "CloudStack"]
3333
def_log_file: /var/log/cloud-init.log
3434
syslog_fix_perms: syslog:adm
3535
"""

config/cloud.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
user: ubuntu
22
disable_root: 1
33
preserve_hostname: False
4-
# datasource_list: ["NoCloud", "ConfigDrive", "OVF", "MaaS", "Ec2", "CloudStack"]
4+
# datasource_list: ["NoCloud", "ConfigDrive", "OVF", "MAAS", "Ec2", "CloudStack"]
55

66
cloud_init_modules:
77
- bootcmd

doc/examples/cloud-config-datasources.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ datasource:
1414
- http://169.254.169.254:80
1515
- http://instance-data:8773
1616

17-
MaaS:
17+
MAAS:
1818
timeout : 50
1919
max_wait : 120
2020

tests/unittests/test_datasource/test_maas.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3,24 +3,24 @@
33
import os
44
from StringIO import StringIO
55
from copy import copy
6-
from cloudinit.DataSourceMaaS import (
7-
MaasSeedDirNone,
8-
MaasSeedDirMalformed,
6+
from cloudinit.DataSourceMAAS import (
7+
MAASSeedDirNone,
8+
MAASSeedDirMalformed,
99
read_maas_seed_dir,
1010
read_maas_seed_url,
1111
)
1212
from mocker import MockerTestCase
1313

1414

15-
class TestMaasDataSource(MockerTestCase):
15+
class TestMAASDataSource(MockerTestCase):
1616

1717
def setUp(self):
18-
super(TestMaasDataSource, self).setUp()
18+
super(TestMAASDataSource, self).setUp()
1919
# Make a temp directoy for tests to use.
2020
self.tmp = mkdtemp(prefix="unittest_")
2121

2222
def tearDown(self):
23-
super(TestMaasDataSource, self).tearDown()
23+
super(TestMAASDataSource, self).tearDown()
2424
# Clean up temp directory
2525
rmtree(self.tmp)
2626

@@ -63,7 +63,7 @@ def test_seed_dir_valid_extra(self):
6363
self.assertFalse(('foo' in metadata))
6464

6565
def test_seed_dir_invalid(self):
66-
"""Verify that invalid seed_dir raises MaasSeedDirMalformed"""
66+
"""Verify that invalid seed_dir raises MAASSeedDirMalformed"""
6767

6868
valid = {'instance-id': 'i-instanceid',
6969
'local-hostname': 'test-hostname', 'user-data': ''}
@@ -75,24 +75,24 @@ def test_seed_dir_invalid(self):
7575
invalid_data = copy(valid)
7676
del invalid_data['local-hostname']
7777
populate_dir(my_d, invalid_data)
78-
self.assertRaises(MaasSeedDirMalformed, read_maas_seed_dir, my_d)
78+
self.assertRaises(MAASSeedDirMalformed, read_maas_seed_dir, my_d)
7979

8080
# missing 'instance-id'
8181
my_d = "%s-02" % my_based
8282
invalid_data = copy(valid)
8383
del invalid_data['instance-id']
8484
populate_dir(my_d, invalid_data)
85-
self.assertRaises(MaasSeedDirMalformed, read_maas_seed_dir, my_d)
85+
self.assertRaises(MAASSeedDirMalformed, read_maas_seed_dir, my_d)
8686

8787
def test_seed_dir_none(self):
88-
"""Verify that empty seed_dir raises MaasSeedDirNone"""
88+
"""Verify that empty seed_dir raises MAASSeedDirNone"""
8989

9090
my_d = os.path.join(self.tmp, "valid_empty")
91-
self.assertRaises(MaasSeedDirNone, read_maas_seed_dir, my_d)
91+
self.assertRaises(MAASSeedDirNone, read_maas_seed_dir, my_d)
9292

9393
def test_seed_dir_missing(self):
94-
"""Verify that missing seed_dir raises MaasSeedDirNone"""
95-
self.assertRaises(MaasSeedDirNone, read_maas_seed_dir,
94+
"""Verify that missing seed_dir raises MAASSeedDirNone"""
95+
self.assertRaises(MAASSeedDirNone, read_maas_seed_dir,
9696
os.path.join(self.tmp, "nonexistantdirectory"))
9797

9898
def test_seed_url_valid(self):
@@ -133,11 +133,11 @@ def my_headers_cb(url):
133133
valid['meta-data/local-hostname'])
134134

135135
def test_seed_url_invalid(self):
136-
"""Verify that invalid seed_url raises MaasSeedDirMalformed"""
136+
"""Verify that invalid seed_url raises MAASSeedDirMalformed"""
137137
pass
138138

139139
def test_seed_url_missing(self):
140-
"""Verify seed_url with no found entries raises MaasSeedDirNone"""
140+
"""Verify seed_url with no found entries raises MAASSeedDirNone"""
141141
pass
142142

143143

0 commit comments

Comments
 (0)