Skip to content
This repository was archived by the owner on Apr 2, 2025. It is now read-only.

Commit 9181d45

Browse files
committed
refactor(rxjs): remove lettable operators
1 parent dd9ee0c commit 9181d45

File tree

5 files changed

+17
-11
lines changed

5 files changed

+17
-11
lines changed

src/app/agents/leads/free/free.component.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
import {Component, OnInit} from '@angular/core';
22
import {NavService} from '../../../nav.service';
33
import {UsersService} from '../../../users.service';
4-
import {of} from 'rxjs/observable/of';
5-
import {take} from 'rxjs/operators';
4+
import {Observable} from 'rxjs/Observable';
65

76
@Component({
87
selector: 'app-free',
@@ -20,10 +19,7 @@ export class FreeComponent implements OnInit {
2019

2120
ngOnInit() {
2221
// Just adding in some operators since they were all removed from this lazy loaded module when making a public example
23-
of([])
24-
.pipe(
25-
take(1)
26-
)
22+
Observable.of([]).take(1)
2723
.subscribe(data => this.data = data);
2824
}
2925
}

src/app/app.component.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import {environment} from '../environments/environment';
55
import {NavService} from './nav.service';
66
import {GoogleAnalyticsService} from './google-analytics.service';
77
import {isPlatformBrowser} from '@angular/common';
8-
import {filter} from 'rxjs/operators';
98

109
@Component({
1110
selector: 'app-root',
@@ -41,10 +40,7 @@ export class AppComponent implements OnInit, AfterViewInit {
4140
};
4241

4342
// scrollTop on newly visited pages
44-
this.router.events
45-
.pipe(
46-
filter(event => event instanceof NavigationEnd)
47-
)
43+
this.router.events.filter(event => event instanceof NavigationEnd)
4844
.subscribe(() => {
4945
if (this.firstUseOfCurrentRoute) {
5046
const scrollingElement = document.scrollingElement || document.documentElement;

src/app/app.module.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import 'hammerjs';
1111
import {
1212
MatAutocompleteModule, MatMenuModule, MatSidenavModule, MatSnackBarModule, MatToolbarModule
1313
} from '@angular/material';
14+
import './rxjs.extensions';
1415

1516
import {AppRoutingModule} from './app-routing.module';
1617
import {SharedModule} from './shared';

src/app/rxjs.extensions.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
// Purposely importing more than I actually need here to test tree shaking
2+
// Just of, take, and filter are used atm.
3+
import 'rxjs/add/operator/catch';
4+
import 'rxjs/add/operator/debounceTime';
5+
import 'rxjs/add/operator/distinctUntilChanged';
6+
import 'rxjs/add/operator/filter';
7+
import 'rxjs/add/operator/map';
8+
import 'rxjs/add/operator/mergeMap';
9+
import 'rxjs/add/operator/switchMap';
10+
import 'rxjs/add/operator/take';
11+
import 'rxjs/add/observable/of';
12+
import 'rxjs/add/observable/throw';

src/test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import {
1111
BrowserDynamicTestingModule,
1212
platformBrowserDynamicTesting
1313
} from '@angular/platform-browser-dynamic/testing';
14+
import './app/rxjs.extensions';
1415

1516
// Unfortunately there's no typing for the `__karma__` variable. Just declare it as any.
1617
declare var __karma__: any;

0 commit comments

Comments
 (0)