Skip to content

Commit 8fd7002

Browse files
throwable-oneintellij-monorepo-bot
throwable-one
authored and
intellij-monorepo-bot
committed
cleanup [python]: remove unused symbols
GitOrigin-RevId: cbefb7c4667b2d2d1a8f38bcddc28fb51a0ce226
1 parent e146a61 commit 8fd7002

25 files changed

Lines changed: 8 additions & 236 deletions

‎platform/util/resources/misc/registry.properties‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1236,7 +1236,6 @@ run.processes.with.redirectedErrorStream.description=Merge standard streams of p
12361236
executor.actions.submenu=true
12371237
executor.actions.submenu.description=Show context execution actions other than Run and Debug in a submenu
12381238

1239-
kill.windows.processes.softly=false
12401239
kill.windows.processes.softly.description=Try to terminate Windows processes gracefully before forcing termination
12411240

12421241
disable.winp=false

‎python/ide/impl/src/com/intellij/pycharm/community/ide/impl/PyIdeCommonOptionsForm.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -305,8 +305,7 @@ private void updateRemoteInterpreterMode() {
305305
return PythonSdkUtil.findSdkByPath(sdkHome);
306306
}
307307

308-
@Override
309-
public void addInterpreterComboBoxActionListener(ActionListener listener) {
308+
private void addInterpreterComboBoxActionListener(ActionListener listener) {
310309
content.interpreterComboBox.addActionListener(listener);
311310
}
312311

‎python/pluginCore/impl/src/com/intellij/python/community/plugin/impl/run/PyPluginCommonOptionsForm.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,7 @@ public JPanel getMainPanel() {
9292
public void subscribe() {
9393
}
9494

95-
@Override
96-
public void addInterpreterComboBoxActionListener(ActionListener listener) {
95+
private void addInterpreterComboBoxActionListener(ActionListener listener) {
9796
content.interpreterComboBox.addActionListener(listener);
9897
}
9998

‎python/pluginJava/src/com/intellij/python/community/plugin/java/facet/JavaPythonFacet.java‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@ public void removeLibrary() {
3131
PythonFacetUtil.removeLibrary(getModule());
3232
}
3333

34-
public static String getFacetLibraryName(final String sdkName) {
35-
return sdkName + PYTHON_FACET_LIBRARY_NAME_SUFFIX;
36-
}
37-
3834
@Override
3935
public void initFacet() {
4036
updateLibrary();

‎python/pluginResources/intellij.python.community.impl.xml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -756,8 +756,6 @@
756756
<extensionPoint qualifiedName="Pythonid.remoteInterpreterManager"
757757
interface="com.jetbrains.python.remote.PythonRemoteInterpreterManager"
758758
dynamic="true"/>
759-
<extensionPoint qualifiedName="Pythonid.remoteConsoleProcessCreator"
760-
interface="com.jetbrains.python.console.PythonConsoleRemoteProcessCreator" dynamic="true"/>
761759
<extensionPoint qualifiedName="Pythonid.breakpointHandler"
762760
interface="com.jetbrains.python.debugger.PyBreakpointHandlerFactory"
763761
dynamic="true"/>

‎python/python-sdk/src/com/jetbrains/python/packaging/IndicatedProcessOutputListener.java‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@
99
import com.intellij.openapi.util.text.StringUtil;
1010
import org.jetbrains.annotations.NotNull;
1111

12+
/**
13+
* @deprecated use {@link com.intellij.execution.process.ProcessListener} directly
14+
*/
15+
@Deprecated(forRemoval = true)
1216
public final class IndicatedProcessOutputListener extends ProcessAdapter {
1317
private final @NotNull ProgressIndicator myIndicator;
1418

‎python/python-sdk/src/com/jetbrains/python/sdk/skeletons/PyLegacySkeletonGenerator.java‎

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -47,19 +47,6 @@ public PyLegacySkeletonGenerator(@NotNull String skeletonPath,
4747
return builder;
4848
}
4949

50-
/**
51-
* @param ensureSuccess throw {@link InvalidSdkException} containing additional diagnostic on process non-zero exit code.
52-
* You might want to disable it for commands where non-zero exit code is possible for situations other
53-
* than misconfigured interpreter or execution error in order to inspect the output manually.
54-
*/
55-
protected @NotNull ProcessOutput runProcess(@NotNull Builder builder, boolean ensureSuccess) throws InvalidSdkException {
56-
ProcessOutput output = builder.runProcess();
57-
if (ensureSuccess && output.getExitCode() != 0) {
58-
throw new InvalidSdkException(formatGeneratorFailureMessage(output));
59-
}
60-
return output;
61-
}
62-
6350
// [targets-api] this should be left as-is because it deals with non-structured `commandLine`
6451
protected @NotNull ProcessOutput getProcessOutput(@Nullable String homePath,
6552
String @NotNull [] commandLine,

‎python/python-sdk/src/com/jetbrains/python/sdk/skeletons/PySkeletonGenerator.java‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -163,16 +163,6 @@ protected Builder() {
163163
return this;
164164
}
165165

166-
public @NotNull Builder timeout(int timeout) {
167-
myTimeout = timeout;
168-
return this;
169-
}
170-
171-
public @NotNull Builder stdin(@NotNull String content) {
172-
myStdin = content;
173-
return this;
174-
}
175-
176166
public @Nullable String getStdin() {
177167
return myStdin;
178168
}

‎python/src/com/jetbrains/python/HelperPackage.java‎

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44
import com.intellij.execution.configurations.GeneralCommandLine;
55
import com.intellij.execution.configurations.ParamsGroup;
6-
import com.intellij.openapi.projectRoots.Sdk;
76
import org.jetbrains.annotations.NotNull;
87

98
import java.util.List;
@@ -36,16 +35,4 @@ public interface HelperPackage {
3635

3736
@NotNull
3837
GeneralCommandLine newCommandLine(@NotNull String sdkPath, @NotNull List<String> parameters);
39-
40-
/**
41-
* Version-sensitive version of {@link #newCommandLine(String, List)}. It adds additional directories with libraries inside python-helpers
42-
* depending on the version of pythonSdk: either {@link PythonHelper#PY2_HELPER_DEPENDENCIES_DIR} or
43-
* {@link PythonHelper#PY3_HELPER_DEPENDENCIES_DIR}.
44-
*
45-
* @param pythonSdk Python SDK containing interpreter that will be used to run this helper
46-
* @param parameters additional command line parameters of this helper
47-
* @return instance {@link GeneralCommandLine} used to start the process
48-
*/
49-
@NotNull
50-
GeneralCommandLine newCommandLine(@NotNull Sdk pythonSdk, @NotNull List<String> parameters);
5138
}

‎python/src/com/jetbrains/python/PythonHelper.java‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -174,8 +174,8 @@ public void addToGroup(@NotNull ParamsGroup group, @NotNull GeneralCommandLine c
174174
return cmd;
175175
}
176176

177-
@Override
178-
public @NotNull GeneralCommandLine newCommandLine(@NotNull Sdk pythonSdk, @NotNull List<String> parameters) {
177+
@NotNull
178+
private GeneralCommandLine newCommandLine(@NotNull Sdk pythonSdk, @NotNull List<String> parameters) {
179179
final String sdkHomePath = pythonSdk.getHomePath();
180180
assert sdkHomePath != null;
181181
final GeneralCommandLine cmd = newCommandLine(sdkHomePath, parameters);
@@ -295,7 +295,6 @@ public void addToGroup(@NotNull ParamsGroup group, @NotNull GeneralCommandLine c
295295
return myModule.newCommandLine(sdkPath, parameters);
296296
}
297297

298-
@Override
299298
public @NotNull GeneralCommandLine newCommandLine(@NotNull Sdk pythonSdk, @NotNull List<String> parameters) {
300299
return myModule.newCommandLine(pythonSdk, parameters);
301300
}

0 commit comments

Comments
 (0)