synonym match of different type is allowed

mcmonkey4eva · mcmonkey4eva · commit 3529b2f67298 · 2023-06-13T02:31:39.000-07:00
diff --git a/SharpDenizenTools/MetaObjects/MetaObject.cs b/SharpDenizenTools/MetaObjects/MetaObject.cs
@@ -136,7 +136,7 @@ public void PostCheckSynonyms<T>(MetaDocs docs, Dictionary<string, T> objects) w
             {
                 docs.LoadErrors.Add($"Object {Name} has synonyms '{string.Join(',', badSynonyms)}' that match existing objects and will break meta searches.");
             }
-            IEnumerable<string> dupSynonyms = Synonyms.Where(s => objects.Values.Any(t => t != this && t.Synonyms.Contains(s)));
+            IEnumerable<string> dupSynonyms = Synonyms.Where(s => objects.Values.Any(t => t != this && t.Type == Type && t.Synonyms.Contains(s)));
             if (dupSynonyms.Any())
             {
                 docs.LoadErrors.Add($"Object {Name} has synonyms '{string.Join(',', dupSynonyms)}' that match other objects existing synonyms and will be invalid for searches.");

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ public void PostCheckSynonyms<T>(MetaDocs docs, Dictionary<string, T> objects) w`
`136`	`136`	`{`
`137`	`137`	`docs.LoadErrors.Add($"Object {Name} has synonyms '{string.Join(',', badSynonyms)}' that match existing objects and will break meta searches.");`
`138`	`138`	`}`
`139`		`- IEnumerable<string> dupSynonyms = Synonyms.Where(s => objects.Values.Any(t => t != this && t.Synonyms.Contains(s)));`
	`139`	`+ IEnumerable<string> dupSynonyms = Synonyms.Where(s => objects.Values.Any(t => t != this && t.Type == Type && t.Synonyms.Contains(s)));`
`140`	`140`	`if (dupSynonyms.Any())`
`141`	`141`	`{`
`142`	`142`	`docs.LoadErrors.Add($"Object {Name} has synonyms '{string.Join(',', dupSynonyms)}' that match other objects existing synonyms and will be invalid for searches.");`